https://bugzilla.redhat.com/show_bug.cgi?id=1822949
Bug ID: 1822949 Summary: Review Request: golang-github-parnurzeal-gorequest - Simplified HTTP client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-parnurzeal-goreque... SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-parnurzeal-goreque...
Project URL: https://github.com/parnurzeal/gorequest
Description: GoRequest is a simplified HTTP client.
Koji scratch build: fails due to missing dependency
rpmlint output: $ rpmlint golang-github-parnurzeal-gorequest-0.2.16-1.fc31.src.rpm golang-github-parnurzeal-gorequest.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint golang-github-parnurzeal-gorequest-devel-0.2.16-1.fc31.noarch.rpm golang-github-parnurzeal-gorequest-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/parnurzeal/gorequest/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1822949
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1822947 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1822947 [Bug 1822947] Review Request: golang-moul-http2curl - Convert Golang's http.Request to curl commands
https://bugzilla.redhat.com/show_bug.cgi?id=1822949
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1822954
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1822954 [Bug 1822954] Review Request: aquatone - Tool for Domain Flyovers
https://bugzilla.redhat.com/show_bug.cgi?id=1822949
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - I've got error in tests:
Testing in: /builddir/build/BUILD/gorequest-0.2.16/_build/src PATH: /builddir/build/BUILD/gorequest-0.2.16/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/gorequest-0.2.16/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/parnurzeal/gorequest/version=0.2.16 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" testing: github.com/parnurzeal/gorequest github.com/parnurzeal/gorequest 2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4: too many open files; retrying in 5ms 2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4: too many open files; retrying in 5ms --- FAIL: TestTimeoutFunc (2.01s) gorequest_test.go:2091: Expected timeout in between 1000 -> 1500 ms | but got 4907426 --- FAIL: TestCookies (0.00s) gorequest_test.go:2129: Cookies test request did not complete FAIL exit status 1 FAIL github.com/parnurzeal/gorequest 2.405s
Seems it's network related so maybe it can't work in Mock. Otherwise LGTM:
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1822949
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-parnurzeal-gorequest
https://bugzilla.redhat.com/show_bug.cgi?id=1822949 Bug 1822949 depends on bug 1822947, which changed state.
Bug 1822947 Summary: Review Request: golang-moul-http2curl - Convert Golang's http.Request to curl commands https://bugzilla.redhat.com/show_bug.cgi?id=1822947
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1822949
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-08-22 19:29:14
package-review@lists.fedoraproject.org