https://bugzilla.redhat.com/show_bug.cgi?id=1876259
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
The URL and Source0 addresses are Ok.
The Source0 archive (SHA-256:
125a1394662e0a45e2696977496c1d027b14387ff6e39b60c07e0f96eae152d3) is original.
Ok.
Summary verified from lib/URI/cpan.pm. Ok.
Description is Ok.
License verified from lib/URI/cpan/distfile.pm, lib/URI/cpan/package.pm,
lib/URI/cpan/module.pm, lib/URI/cpan/author.pm, lib/URI/cpan/dist.pm,
lib/URI/cpan.pm, Makefile.PL, LICENSE, and README. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Consider using %{make_install} macro with Makefile.PL NO_PACKLIST=1
NO_PERLLOCAL=1.
FIX: Move 'perl(URI)' BuildRequires to tests section (t/uri-cpan.t:4). It's
not
used at a run-time.
All tests pass. Ok.
$ rpmlint perl-URI-cpan.spec ../SRPMS/perl-URI-cpan-1.007-2.fc34.src.rpm
../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm
drwxr-xr-x 2 root root 0 Sep 15 15:41
/usr/share/doc/perl-URI-cpan
-rw-r--r-- 1 root root 632 Apr 17 2015
/usr/share/doc/perl-URI-cpan/Changes
-rw-r--r-- 1 root root 372 Apr 17 2015
/usr/share/doc/perl-URI-cpan/README
drwxr-xr-x 2 root root 0 Sep 15 15:41
/usr/share/licenses/perl-URI-cpan
-rw-r--r-- 1 root root 18355 Apr 17 2015
/usr/share/licenses/perl-URI-cpan/LICENSE
-rw-r--r-- 1 root root 1796 Sep 15 15:41
/usr/share/man/man3/URI::cpan.3pm.gz
-rw-r--r-- 1 root root 1298 Sep 15 15:41
/usr/share/man/man3/URI::cpan::author.3pm.gz
-rw-r--r-- 1 root root 1296 Sep 15 15:41
/usr/share/man/man3/URI::cpan::dist.3pm.gz
-rw-r--r-- 1 root root 1599 Sep 15 15:41
/usr/share/man/man3/URI::cpan::distfile.3pm.gz
-rw-r--r-- 1 root root 1298 Sep 15 15:41
/usr/share/man/man3/URI::cpan::module.3pm.gz
-rw-r--r-- 1 root root 1300 Sep 15 15:41
/usr/share/man/man3/URI::cpan::package.3pm.gz
drwxr-xr-x 2 root root 0 Sep 15 15:41
/usr/share/perl5/vendor_perl/URI
drwxr-xr-x 2 root root 0 Sep 15 15:41
/usr/share/perl5/vendor_perl/URI/cpan
-rw-r--r-- 1 root root 3601 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan.pm
-rw-r--r-- 1 root root 857 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan/author.pm
-rw-r--r-- 1 root root 509 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan/dist.pm
-rw-r--r-- 1 root root 2540 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan/distfile.pm
-rw-r--r-- 1 root root 515 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan/module.pm
-rw-r--r-- 1 root root 518 Apr 17 2015
/usr/share/perl5/vendor_perl/URI/cpan/package.pm
A file layout and the permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm |
sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(Carp)
1 perl(CPAN::DistnameInfo)
1 perl(parent)
1 perl(strict)
1 perl(URI::cpan)
1 perl(URI::cpan::author)
1 perl(URI::cpan::dist)
1 perl(URI::cpan::distfile)
1 perl(URI::cpan::module)
1 perl(URI::cpan::package)
1 perl(URI::_generic)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm |
sort -f | uniq -c
1 perl(URI::cpan) = 1.007
1 perl(URI::cpan::author) = 1.007
1 perl(URI::cpan::dist) = 1.007
1 perl(URI::cpan::distfile) = 1.007
1 perl(URI::cpan::module) = 1.007
1 perl(URI::cpan::package) = 1.007
1 perl-URI-cpan = 1.007-2.fc34
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F34
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=51510948). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' item, and consider fixing the 'TODO' item before
building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component