Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Lubomir Rintel <lkundrak(a)v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lkundrak(a)v3.sk
--- Comment #5 from Lubomir Rintel <lkundrak(a)v3.sk> 2012-01-08 17:48:36 EST ---
* Name alright
* Versioning correct
* Source file matches upstream
* SPEC file clean and legible
* Builds fine in mock
1.) Require list not correct
Requires: ruby(abi) = 1.8
Please drop this -- you don't install modules into 1.8 release specific
location and thus don't need to require a particular ABI.
2.) Licensing is suspicious
You need to clarify this:
# Unknown license (same as JQuery?)
%{app_root}/public/js/jquery.batchImageLoad.js
%{app_root}/public/js/jquery.uuid.js
3.) Rpmlint not happy
showoff.src:60: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built. Add default attributes using
%defattr before it in the %files section, or use per line %attr's.
showoff.src: W: no-%clean-section
The spec file doesn't contain a %clean section to remove the files installed
by the %install section.
showoff.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.