https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Bug ID: 2235550 Summary: Review Request: kf6 - Filesystem and RPM macros for KDE Frameworks 6 Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: justin.zobel@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://1707.io/jz/kf6.spec SRPM URL: https://1707.io/jz/kf6-6-1.fc38.src.rpm
Description: Fedora Account System Username: justinz
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.kde.org
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6351459 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
License: BSD
This is no longer valid, we need it to be a valid SPDX license
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
We don't seem to have a license text to go with this, and neither does kf5 (which it was forked from).
We should be able to go ahead and put in a BSD-3-Clause license file in both projects and just set this to BSD-3-Clause, though.
%if 0%{?fedora} || 0%{?rhel} > 7 Requires: cmake >= 3 Requires: qt6-rpm-macros >= 6 %else Requires: cmake3 Requires: qt6-qtbase-devel >= 6 %endif
We are not building this for anything older than EPEL 9, so we can simplify this logic to:
Requires: cmake >= 3 Requires: qt6-rpm-macros >= 6
%if 0%{?rhel} == 8 # This is where cmake-related macros live, e.g. %%cmake_build, %%cmake_install # at least until fixed upstream, https://bugzilla.redhat.com/show_bug.cgi?id=1858941 Requires: epel-rpm-macros %endif
This can be dropped. This was fixed a long time ago. Same for in EPEL 8.
%if 0%{?rhel} && 0%{?rhel} < 8 -e 's|%{__cmake}|%{__cmake3}|' \ %endif
This can be dropped.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- (In reply to Neal Gompa from comment #3)
%if 0%{?rhel} == 8 # This is where cmake-related macros live, e.g. %%cmake_build, %%cmake_install # at least until fixed upstream, https://bugzilla.redhat.com/show_bug.cgi?id=1858941 Requires: epel-rpm-macros %endif
This can be dropped. This was fixed a long time ago. Same for in EPEL 8.
Sorry, I meant same for kf5.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
--- Comment #5 from Justin Zobel justin.zobel@gmail.com --- Updated with all requested changes.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package complies with Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct and license file is correctly installed * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2235556
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2235556 [Bug 2235556] KF6-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2235550
Justin Zobel justin.zobel@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-09-28 00:28:22
package-review@lists.fedoraproject.org