Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453839
--- Comment #12 from Orcan 'oget' Ogetbil <orcanbahri(a)yahoo.com> 2008-12-19
12:14:59 EDT ---
(In reply to comment #10)
Thank you for taking this review.
You're welcome
Changelog :
- subpckage created for nautilus extension
I am a gnome-ignorant. How do I test this extension? I couldn't find anything
in nautilus related to phatch. But it's probably me. I always find gnome too
confusing.
Requires: %{name} = %{version}
should be
Requires: %{name} = %{version}-%{release}
Also, please add the license file at the least as a %doc to this package.
- whole documentation included
Thanks. But now there is a docs
subdirectory in a directory which is already
for docs. I don't think this is elegant. Try using "docs/*" in %doc instead
of
just "docs"
I tried to use scrollkeeper but no additionnal documentation was
generated, so
I removed it.
Sorry I meant sections 4.7 or 4.8 (or they just added another section between
my review and you seeing it)
I also contacted upstream about the software version (egg file
generated
contains "0.1.5" instead of "0.1.6" and the "about" dialog
display also "0.1.5"
instead of "0.1.6").
Until they fix it (possibly until next version), you can use:
sed -e 's|0\.1\.5|0\.1\.6|' -e 's|20080606224435|200811091037|' \
phatch/data/version.py > phatch/data/version.py.16
touch -c -r phatch/data/version.py phatch/data/version.py.16
mv phatch/data/version.py.16 phatch/data/version.py
This will fix both the python egg and the about dialog.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.