https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Bug ID: 1516328 Summary: Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: jar.prokop@volny.cz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/0c4eecca79b92c9208675357... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat... Description: Helps creating valid Guard plugins and testing them. Fedora Account System Username: jackorp Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23300282
This is my first package so please be nice to me.
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@redhat.com Assignee|nobody@fedoraproject.org |vondruch@redhat.com Flags| |fedora-review?
--- Comment #1 from Vít Ondruch vondruch@redhat.com --- I'll take it for a review and I can sponsor you as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1268695
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1268696 CC| |ilya.gradina@gmail.com
--- Comment #2 from Ilya Gradina ilya.gradina@gmail.com --- *** Bug 1268695 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1268696 [Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
--- Comment #3 from Vít Ondruch vondruch@redhat.com --- * Hidden files - rpmlint complains:
~~~ rubygem-guard-compat.noarch: W: hidden-file-or-dir /usr/share/gems/gems/guard-compat-1.2.1/.rubocop_todo.yml ~~~
but it would be probably good idea to get rid of all the hidden file by one sweep, e.g. to replace:
~~~ %exclude %{gem_instdir}/.gitignore %exclude %{gem_instdir}/.rubocop.yml %{gem_instdir}/.rubocop_todo.yml %exclude %{gem_instdir}/.rspec ~~~
by just single line:
~~~ %exclude %{gem_instdir}/.* ~~~
* Missing URL - There is no URL tag in the .spec file. There should probably be some, e.g.:
~~~ URL: https://github.com/guard/guard-compat ~~~
Otherwise the package looks good. Please fix these two nits and I'll approve this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
--- Comment #4 from Jaroslav Prokop jar.prokop@volny.cz --- Updated spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/fbb428b56066c1490c53750e...
Updated srpm URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat...
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23440326
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1268698
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1268698 [Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1526056
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1526056 [Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1526056 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1526056 [Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- Thx. I can't see any other issue with the package => APPROVED. Please continue with the SCM request, import and build of the package:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_P... age_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-guard-compat
https://bugzilla.redhat.com/show_bug.cgi?id=1516328
Jaroslav Prokop jar.prokop@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |rubygem-guard-compat-1.2.1- | |1.fc28 Resolution|--- |RAWHIDE Last Closed| |2017-12-18 10:27:43
package-review@lists.fedoraproject.org