Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Summary: Package review: perl-Padre Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: low Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmaslano@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
The application maintains its configuration information in a directory called .padre
http://mmaslano.fedorapeople.org/Padre/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Package review: perl-Padre
https://bugzilla.redhat.com/show_bug.cgi?id=457517
------- Additional Comments From mmaslano@redhat.com 2008-08-01 05:48 EST ------- I can't pass test and the same problem appears after installation. The application is running as I can say, but it should be removed before adding into Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Package review: perl-Padre
https://bugzilla.redhat.com/show_bug.cgi?id=457517
------- Additional Comments From mmaslano@redhat.com 2008-08-01 05:49 EST ------- Created an attachment (id=313173) --> (https://bugzilla.redhat.com/attachment.cgi?id=313173&action=view) Warning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Package review: perl-Padre |Review Request: perl-Padre
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: perl-Padre |Review Request: perl-Padre | |- Perl Application | |Development and Refactoring | |Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |458653 Customer Facing| |---
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |458669
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 458669, which changed state.
Bug 458669 Summary: Review Request: perl-File-ShareDir https://bugzilla.redhat.com/show_bug.cgi?id=458669
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 458653, which changed state.
Bug 458653 Summary: Review Request: perl-Devel-PerlySense - Perl IDE backend with Emacs frontend https://bugzilla.redhat.com/show_bug.cgi?id=458653
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |460867
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|460867 |
--- Comment #3 from Marcela Maslanova mmaslano@redhat.com 2008-09-02 04:04:59 EDT --- Update to new version http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.06-1.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #4 from Rakesh Pandit rakesh.pandit@gmail.com 2008-09-02 05:23:29 EDT --- Same here. Spec file, description of package ? Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #5 from Marcela Maslanova mmaslano@redhat.com 2008-09-02 06:30:33 EDT --- The spec http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec
Official description is quite short. Let's made up new one.
Description: Padre is a text editor aimed to be an IDE for Perl. The application maintains its configuration information in a directory called .padre.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |460867
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |463761, 463763
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |463768, 463771, 463766
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Matej Cepl mcepl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|463761 |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463771, which changed state.
Bug 463771 Summary: Package review: perl-Probe-Perl https://bugzilla.redhat.com/show_bug.cgi?id=463771
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463763, which changed state.
Bug 463763 Summary: Package review: perl-Module-Inspector https://bugzilla.redhat.com/show_bug.cgi?id=463763
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463766, which changed state.
Bug 463766 Summary: Package review: perl-Wx-Perl-Dialog https://bugzilla.redhat.com/show_bug.cgi?id=463766
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463768, which changed state.
Bug 463768 Summary: Package review: perl-PAR https://bugzilla.redhat.com/show_bug.cgi?id=463768
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 460867, which changed state.
Bug 460867 Summary: Review Request: perl-ORLite - Extremely light weight SQLite-specific ORM https://bugzilla.redhat.com/show_bug.cgi?id=460867
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #6 from Marcela Maslanova mmaslano@redhat.com 2008-10-03 03:54:37 EDT --- http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-1.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #7 from Marcela Maslanova mmaslano@redhat.com 2008-10-03 04:29:51 EDT --- The tests should be switched off for inclusion, because it needs graphic. I've also problem with one test and I reported this into upstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #8 from Marcela Maslanova mmaslano@redhat.com 2008-10-08 07:56:21 EDT --- This test should be ignored in the meantime, please review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |dan@danny.cz Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #9 from Dan Horák dan@danny.cz 2008-10-10 05:45:36 EDT --- formal review is here, see the notes below:
OK source files match upstream: d810f98c2b56bb54d89d1a41596d8fbddfdf699c Padre-0.10.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A* %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD* doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. BAD is a GUI app, desktop file is missing
- rpmlint complains perl-Padre.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Padre/Wx/Ack.pm remove the executable bits perl-Padre.noarch: E: non-executable-script /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl 0644 perl-Padre.noarch: E: non-executable-script /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.t 0644 when /auto/share/dist/Padre/templates/* must be packaged (it is required for Padre to work correctly), then you should package 2 dirs %{perl_vendorlib}/Padre + %{perl_vendorlib}/auto/share/dist/Padre, but not the whole %{perl_vendorlib}/* hierarchy - tests requires running X, so the check section is disabled, but the proper BR: can exist in the spec (commented out) - it is a GUI application, but desktop file is missing - when running Padre in mock/Rawhide I got an error "libwx_gtk2u_stc-2.8.so: cannot open shared object file: No such file or directory", window title "Padre::Wx::App Error" - looks like something wants to open development version of this library even when the runtime lib is installed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #10 from Marcela Maslanova mmaslano@redhat.com 2008-10-10 07:29:23 EDT --- This example and test should have permission 644 /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl
Desktop file wasn't included in upstream source. Should I create it or file a bug to upstream?
The error "libwx_gtk2u_stc-2.8.so:..." wasn't resolved by upstream till now, but he's working on solution.
http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #11 from Dan Horák dan@danny.cz 2008-10-10 07:39:55 EDT --- (In reply to comment #10)
This example and test should have permission 644 /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl
ok
Desktop file wasn't included in upstream source. Should I create it or file a bug to upstream?
please create one - https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
The error "libwx_gtk2u_stc-2.8.so:..." wasn't resolved by upstream till now, but he's working on solution.
ok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #12 from Marcela Maslanova mmaslano@redhat.com 2008-10-10 08:57:35 EDT --- http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-3.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #13 from Marcela Maslanova mmaslano@redhat.com 2008-10-15 02:38:01 EDT --- http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-4.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #14 from Dan Horák dan@danny.cz 2008-10-15 02:46:04 EDT --- All issues fixed, package is APPROVED. But remove the "--add-category" parameter when calling desktop-file-install (category is already set in the dekstop file itself) before import.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #15 from Marcela Maslanova mmaslano@redhat.com 2008-10-15 02:54:06 EDT --- New Package CVS Request ======================= Package Name: perl-Padre Short Description: text editor aimed to be an IDE for Perl Owners: mmaslano Branches: F-10 rawhide InitialCC: fedora-perl-devel-list@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
--- Comment #16 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2008-10-15 05:59:32 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Huzaifa S. Sidhpurwala huzaifas@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #17 from Marcela Maslanova mmaslano@redhat.com 2008-10-15 07:01:44 EDT --- Should be in F-10 perl-Padre-0.10-4.fc10.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463768, which changed state.
Bug 463768 Summary: Package review: perl-PAR https://bugzilla.redhat.com/show_bug.cgi?id=463768
What |Old Value |New Value ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463768, which changed state.
Bug 463768 Summary: Package review: perl-PAR https://bugzilla.redhat.com/show_bug.cgi?id=463768
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE
package-review@lists.fedoraproject.org