https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Bug ID: 2254883 Summary: Review Request: rust-fend-core - Arbitrary-precision unit-aware calculator Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: albertlarsan@unbon.cafe QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co... SRPM URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co...
Description: Arbitrary-precision unit-aware calculator.
Fedora Account System Username: albertlarsan68
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/fe | |nd-core
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6765362 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags| |fedora-review? Status|NEW |ASSIGNED CC| |michel@michel-slm.name
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #2 from Michel Lind michel@michel-slm.name --- Do you specifically need 1.3.x for something? Otherwise, 1.4.1 just came out and 1.4.x was first release several weeks ago
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #3 from Albert Larsan albertlarsan@unbon.cafe --- I do not need 1.3.x, it is just because 1.3.3 was the latest version when I made the package.
Should I post new SRPM & Specs with the 1.4.x version?
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #4 from Michel Lind michel@michel-slm.name --- Yes please - if there's no reason you need the old version, do update with the latest. If it had been just a patch release I'd review now and ask you to update before importing, but since it's a minor release, might as well do it before continuing the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #5 from Albert Larsan albertlarsan@unbon.cafe --- Spec URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co... SRPM URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co...
Updated!
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2007881 --> https://bugzilla.redhat.com/attachment.cgi?id=2007881&action=edit The .spec file difference from Copr build 6765362 to 6875367
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6875367 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #8 from Michel Lind michel@michel-slm.name --- This mostly looks fine, except... upstream does not ship the license file in the crate (sorry for not catching that earlier!).
This is a common issue where upstream has one repo hosting multiple crates, I suggest the following:
- send one PR to https://github.com/printfn/fend symlinking the license file and any other relevant files to the individual crate directories. I normally use `cargo package --allow-dirty --no-verify` followed by `tar tf .. | grep LICENSE` to demonstrate the license files get picked up
- put the PR as a comment above a new Source: https://raw.githubusercontent.com/printfn/fend/main/LICENSE.md line
- in %prep, `cp -p %{SOURCE1} .` to copy in the license file
- in %files devel, replace #FIXME with %license %{crate_instdir}/LICENSE.md
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #9 from Albert Larsan albertlarsan@unbon.cafe --- Spec URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co... SRPM URL: https://albertlarsan68.fedorapeople.org/packages/rust-fend-core/rust-fend-co...
PR is https://github.com/printfn/fend/pull/260, and the package builds and installs.
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2008241 --> https://bugzilla.redhat.com/attachment.cgi?id=2008241&action=edit The .spec file difference from Copr build 6875367 to 6881622
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6881622 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #12 from Michel Lind michel@michel-slm.name --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (GPL-3.0-or-later) and is acceptable for Fedora - [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
--- Comment #13 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fend-core
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-68964eed86 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-68964eed86
https://bugzilla.redhat.com/show_bug.cgi?id=2254883
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-01-18 17:06:28
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-68964eed86 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org