Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-bunny - A synchronous Ruby AMQP client
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Summary: Review Request: rubygem-bunny - A synchronous Ruby AMQP client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rpms@courteau.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-bunny/rub... SRPM URL: http://rpms.courteau.org/fedora/rubygem-bunny-0.7.9-1.fc17.src.rpm Description: A synchronous Ruby AMQP client that enables interaction with AMQP-compliant brokers.
This is the first part of a set of dependencies for rubygem-chef. I've got about 14 packages to add, all ruby gems, and am looking for a sponsor. Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #1 from Vít Ondruch vondruch@redhat.com --- Please note that rubygem-bunny was already in Fedora [1] but has been retired.
[1] https://admin.fedoraproject.org/pkgdb/acls/name/rubygem-bunny
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823352
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Jonas Courteau rpms@courteau.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 |
https://bugzilla.redhat.com/show_bug.cgi?id=821285
Julian C. Dunn jdunn@aquezada.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdunn@aquezada.com
--- Comment #2 from Julian C. Dunn jdunn@aquezada.com --- Since there's been no word from Jonas since the summer, I'm starting to take over the work on these packages. I have a new spec and SRPM for rubygem-bunny:
http://jdunn.fedorapeople.org/rubygem-bunny/rubygem-bunny.spec http://jdunn.fedorapeople.org/rubygem-bunny/rubygem-bunny-0.8.0-1.fc19.src.r...
I'm prepared to undeprecate the existing Fedora package, as well as maintain this one for EPEL6.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmorsi@redhat.com Assignee|nobody@fedoraproject.org |mmorsi@redhat.com Flags| |fedora-cvs?
--- Comment #3 from Mo Morsi mmorsi@redhat.com --- Sorry for the delay, taking this one
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Mo Morsi mmorsi@redhat.com --- rpmlint produces a couple warnings, nothing serious but the macro-in-comment ones should be taken care of (just remove those comments)
rubygem-bunny.src:73: W: macro-in-comment %{buildroot} rubygem-bunny.src:73: W: macro-in-comment %{gem_instdir}
md5sums:
$ md5sum bunny-0.8.0.gem.* 4fc1d4b2a448538ec88c1ad9ed2c5335 bunny-0.8.0.gem.srpm 4fc1d4b2a448538ec88c1ad9ed2c5335 bunny-0.8.0.gem.upstream
Builds fine in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4713563
Shame we can't run the tests, but looks like it for the same reason we aren't running them in the rubygem-pg rpm as a running server is required. Would be nice to look into a way to mock this stuff somehow at some point (perhaps we can build a component to take care of both cases if it doesn't exist), but obviously not a blocker for inclusion.
Lastly I just want to ensure excluding the Gemfile from the package won't pose a problems. I did quickly try one of the examples from the rpm and it worked so I assume all is good.
Everything else looks fine and is in accordance w/ the guidelines.
ACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Julian C. Dunn jdunn@aquezada.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Julian C. Dunn jdunn@aquezada.com --- Package Change Request ====================== Package Name: rubygem-bunny New Branches: fc16 fc17 fc18 el6 Owners: jdunn InitialCC:
Unretiring rubygem-bunny.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-bunny-0.7.9-2.fc16
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-bunny-0.7.9-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-bunny-0.7.9-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- Package rubygem-bunny-0.7.9-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-bunny-0.7.9-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-19645/rubygem-bunny-0.7.... then log in and leave karma (feedback).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-13 00:49:57
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-bunny-0.7.9-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org