https://bugzilla.redhat.com/show_bug.cgi?id=1140195
Bug ID: 1140195 Summary: Review Request: Paper Shaper - Provides random wallpaper from webcams or saved images or both Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bugzilla@pkcarlisle.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.pkcarlisle.com/rpm-paprshapr/papershaper.spec SRPM URL: http://www.pkcarlisle.com/rpm-paprshapr/papershaper-1-1.src.rpm
Description: With Paper Shaper:
1 choose a random offline image as wallpaper from any JPG image stored in ~/com.pkcarlisle/papershaper/gallery/ ...OR...
2 choose a random online image as wallpaper from any webcam from a user maintained list in ~/com.pkcarlisle/papershaper/webcamgrab.txt ...OR...
3 choose a random image as wallpaper from either a user stored offline gallery image OR an online webcam (Paper Shaper decides) ...AND...
4 choose how often the wallpaper updates
5 Docs, setup screen shots, manual install tarball available at https://code.google.com/p/paper-shaper-random-wallpaper-tool/ Fedora Account System Username:pkcarlisledotcom
NOTES: 1 This is the first package I have submitted for Red Hat/CentOS/Fedora. I do need a sponsor. 2 I am looking to have this package in EPEL, as I use CentOS regularly, Fedora rarely. 3 This program has been working on my CentOS 6 box for 6 months. It plays well with others, stable, no problems. Only the RPM packaging is new. 4 I installed the RPM successfully on CentOS 6 and Fedora 20.
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
pkcarlisle-dot-com bugzilla@pkcarlisle.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.pkcarlisle.com/r | |pm-paprshapr/ CC| |bugzilla@pkcarlisle.com Component|Package Review |Package Review Hardware|All |noarch Version|rawhide |el6 Product|Fedora |Fedora EPEL
--- Comment #1 from pkcarlisle-dot-com bugzilla@pkcarlisle.com --- Before the RPM addition, Paper Shaper has also been manually installed in KDE4. It works fine in KDE 4 (Kubuntu 12.04 LTS), Gnome 2 (CentOS 6 / RHEL 6), MATE (Fedora 20).
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|Package Review |Package Review Version|el6 |rawhide Product|Fedora EPEL |Fedora
--- Comment #2 from Christopher Meng i@cicku.me --- (In reply to pkcarlisle-dot-com from comment #1)
Who is pkcarlisle-dot-com behind?
I really can't figure out what this package is. It violates FHS as well:
/com.pkcarlisle/papershaper/
And even if this is a pretty small package, I think you need to cleanup the spec, it's messy.
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
--- Comment #3 from pkcarlisle-dot-com bugzilla@pkcarlisle.com --- Hi, thanks for commenting.
Who is pkcarlisle-dot-com behind?
I am sorry, I do not understand this question. pkcarlisle.com is my own domain. I wrote this utility because I use Linux and I thought this program was a nice enhancement to a desktop. That's all. No deep ulterior motive. No conspiracy-theory-deeply-hidden-corporate connection. Just me and my little Linux box.
I really can't figure out what this package is. It violates FHS as well:
I am not sure I can explain what the package IS better than I already have done.
I am new to the prospect of submitting RPMs for inclusion in Linux. There are doubtless many things I do not know. That is why I have submitted this for review.
With regard to the FHS, I wrote this program explicitly with the idea of providing individual users their own a) individual b) individually customizable and c) automated wallpaper randomizer. So I set it up to install in each user's /home/ folders individually. If this violates an inviolable standard (is the standard inviolable?) no doubt the review process will help determine that and/or a better approach.
And even if this is a pretty small package, I think you need to cleanup the spec, it's messy.
I am new to making RPMs and I welcome any specific criticisms I can address. “It's messy” is not something I can specifically address.
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
pkcarlisle-dot-com bugzilla@pkcarlisle.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
--- Comment #4 from Michael Schwendt bugs.michael@gmx.net ---
Who is pkcarlisle-dot-com behind?
Write it more as a real name in all places, in the bugzilla account preferences, in the spec file %changelog: "P.K. Carlisle" would be one expected way to write it. Don't use "pkcarlisle-dot-com" even if it resembles your full name.
I really can't figure out what this package is. It violates FHS as well:
It doesn't even build. That's no surprise, because no source code archive is included. The spec file accesses paths/files not included in the src.rpm.
As a minimum, people who submit packages for review should examine a few Fedora packages (via src.rpms or git) and follow well-known documentation:
https://fedoraproject.org/wiki/Category:Package_Maintainers
Notice the index at the bottom.
Buildroot: %{_sourcedir}
I would estimate that none of the many thousand Fedora (and Red Hat) packages does it like that, especially since the purpose of the "Buildroot" is a different one and clearly _not_ the same as %_sourcedir. Nowadays, one doesn't set this tag anymore, btw:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
Susi Lehtola susi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Paper |Review Request: papershaper |Shaper - Provides random |- Provides random wallpaper |wallpaper from webcams or |from webcams or saved |saved images or both |images or both
https://bugzilla.redhat.com/show_bug.cgi?id=1140195
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |msuchy@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | Resolution|--- |NOTABUG Last Closed| |2015-10-20 16:57:39
--- Comment #5 from Miroslav Suchý msuchy@redhat.com --- Closing per #4. Please reopen when you provide better spec.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
package-review@lists.fedoraproject.org