https://bugzilla.redhat.com/show_bug.cgi?id=2138969
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
Doc Type|--- |If docs needed, set a value
Assignee|nobody(a)fedoraproject.org |mtasaka(a)fedoraproject.org
Status|NEW |ASSIGNED
--- Comment #1 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Just a quick glance, but:
* Meanwhile, 0.4.0 is out, would you update?
* URL seems wrong, the correct one seems
https://github.com/ruby/timeout
* So this rpmspec file has "BR: rubygem(rake) , bundler and so on, but actually
no %check?
By the way, you can just use rake for %check if it is necessary, but in this
case
it seems the testsuite can be executed by:
$ ruby -I.:lib -rtest/lib/helper -e 'Dir.glob("test/**/test_*.rb").each
{|f|
require f}'
(Actually you can check this by Rakefile:
https://github.com/ruby/timeout/blob/413194f8d2650c6ca7b2a45b38f8c9aca53b...
)
Note that with 0.4.0, now testsuite uses rubygem-test-unit-ruby-core (which
was just approved
by you!):
https://github.com/ruby/timeout/commit/1c91ac24227bb927ce4b341c6184c989a7...
* Rakefile is something like Makefile written in ruby, and personally I don't
package this
into final binary rpm, but this is not a blocker.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2138969
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...