https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Bug ID: 2065451 Summary: Review Request: rust-serde_qs - Querystrings for Serde Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jan@baudisch.xyz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... Description: Querystrings for Serde Fedora Account System Username: janbaudisch
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=84341882
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Are you still interested in packaging this crate? If yes, please refresh the packaging with rust2rpm 21.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... Description: Querystrings for Serde Fedora Account System Username: janbaudisch
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=86575663
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #2 from Jan Baudisch jan@baudisch.xyz --- Refreshed with rust2rpm 21.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Several feature subpackages are not installable due to broken dependencies:
- actix-web2: only actix-web 3 is packaged for Fedora right now - actix-web4: only actix-web 3 is packaged for Fedora right now - axum-framework: axum is not packaged for Fedora yet
Assuming you don't need serde_qs support for any of those web frameworks, just disable the feature subpackages. This can be achieved in three different ways:
1) patch Cargo.toml to remove the features (and optional dependencies) you don't need / want 2) manually remove the broken feature subpackages you don't need / want 3) create a .rust2rpm.conf config file to specify which feature subpackages should not be generated (this basically automates option 2):
[DEFAULT] unwanted-features = actix-web2 actix-web4 axum
If you place this file into the directory where you run rust2rpm, it will use the settings from it during .spec generation. I would recommend this option, since you can also commit this .rust2rpm.conf file into dist-git to preserve these settings for future updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... Description: Querystrings for Serde Fedora Account System Username: janbaudisch
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=86794068
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #4 from Jan Baudisch jan@baudisch.xyz --- Thank you for pointing this out. I updated the package with the rust2rpm config file. On a side note: How can I check for broken dependencies?
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- You can either:
1) run a local mock build as usual and then use "mock -r whatever-buildroot-you-used install ./path-to-built-rpms/*.noarch.rpm" 2) run your local mock build with "--postinstall", which will print installation errors after the build finishes
And given that the "actix2", "actix4", and "axum-framework" features depend on those that you already disabled, you'll need to drop them, as well. Executing a mockbuild and installing the results (either manually or by using --postinstall) should succeed without installability errors.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #6 from Jan Baudisch jan@baudisch.xyz --- Ok, thank you for explaining. I removed the actix{1,2} features and all the subpackages install now.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-serde_qs/rust-serd... Description: Querystrings for Serde Fedora Account System Username: janbaudisch
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=86798306
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Looks good to me now, thanks.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #8 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_qs
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-5e53455c58 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5e53455c58
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-05-09 16:12:58
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-5e53455c58 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d890594d59 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d890594d59
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd328e7548 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd328e7548
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d890594d59 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d890594d59 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d890594d59
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd328e7548 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fd328e7548 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd328e7548
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d890594d59 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2065451
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fd328e7548 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org