https://bugzilla.redhat.com/show_bug.cgi?id=1770784
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
TODO: If you add option 'NO_PERLLOCAL=1' to 'perl Makefile.PL ...'
then you can remove
rm -f $RPM_BUILD_ROOT/%{_libdir}/perl5/perllocal.pod
License
FIX: The license is 'GPLv2+ or Artistic'
Check the section 'LICENSE AND COPYRIGHT' in the Callsite.pm
Ok
BuildRequires:
FIX: Please add following buil-requires:
- perl(B) - t/01callsite.t:4
- perl(warnings) - t/01callsite.t:2
Ok
FIX: Please remove packlist. The easier way to remove .packlist is
used
NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76.
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
NO_PACKLIST=1
Ok
TODO: In spec file, please consider replacing
1)
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
by
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
NO_PACKLIST=1 NO_PERLLOCAL=1
%make_build
Ok
2)
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
by
%make_install
Ok
Please consider fixing 'TODO' item.
Resolution:
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component