https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Bug ID: 1401344 Summary: Review Request: CuraEngine-lulzbot - Engine for processing 3D models into G-code instructions for 3D printers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhroncok@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot-15.04-5.fc25.sr...
Description:
CuraEngine-lulzbot is a C++ console application for 3D printing G-code generation. It has been made as a better and faster alternative to the old Skeinforge engine.
This is just a console application for G-code generation. For a full graphical application look at cura-lulzbot with is the graphical frontend for CuraEngine-lulzbot.
Fedora Account System Username: churchyard
This is package rename from CuraEngine to CuraEngine-lulzbot.
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1393176
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1393176 [Bug 1393176] Upstream has changed and there is a newer version available
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- (There are no Provides and Obsoletes, because CuraEngine will stay in Fedora but will get updated.)
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |tcallawa@redhat.com Flags| |fedora-review?
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com --- At some point, the lulzbot fork will move to the current cura version, but this makes sense for now.
= Review =
- rpmlint returns: CuraEngine-lulzbot.src: E: description-line-too-long C CuraEngine-lulzbot is a C++ console application for 3D printing G-code generation. It CuraEngine-lulzbot.src: E: description-line-too-long C application look at cura-lulzbot with is the graphical frontend for CuraEngine-lulzbot. CuraEngine-lulzbot.src:11: W: macro-in-comment %{name} CuraEngine-lulzbot.src:11: W: macro-in-comment %{version}
These are all easily fixed, please do it. (There are other rpmlint warnings emitted, but they are all safe to ignore).
- package meets naming guidelines - package meets packaging guidelines - license (AGPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Fix the rpmlint issues and I'll approve.
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot-15.04-5.fc25.sr...
Fixed description length and macros in comments. Thanks for the feedback.
I also plan to build this in F24 and F25 (even though CuraEngine will only change in rawhide) so we can maintain just one spec for cura-lulzbot without ifs. Agreed?
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Tom "spot" Callaway tcallawa@redhat.com --- Agreed, and approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/CuraEngine-lulzbot
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- cura-lulzbot-21.02-2.fc25 CuraEngine-lulzbot-15.04-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-470bdc9696
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- cura-lulzbot-21.02-2.fc24 CuraEngine-lulzbot-15.04-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-458edd9f9a
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- CuraEngine-lulzbot-15.04-5.fc25, cura-lulzbot-21.02-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-470bdc9696
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- CuraEngine-lulzbot-15.04-5.fc24, cura-lulzbot-21.02-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-458edd9f9a
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-31 01:48:10
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- CuraEngine-lulzbot-15.04-5.fc25, cura-lulzbot-21.02-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1401344
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- CuraEngine-lulzbot-15.04-5.fc24, cura-lulzbot-21.02-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org