https://bugzilla.redhat.com/show_bug.cgi?id=979332
--- Comment #5 from Jozef Mlich <jmlich(a)redhat.com> ---
(In reply to Volker Fröhlich from comment #4)
(In reply to Jozef Mlich from comment #1)
> This is my first package and you need a sponsor.
What's that about then?
I have no idea what group that is, but I can't see it via FAS.
I am sorry, I am not very familiar with all processes in Fedora. I followed
tutorial 'how to add new package into fedora'. My mentor in Red Hat explained
me, I do not need mentor any more.
I need just review for package.
(In reply to Volker Fröhlich from comment #2)
The .so symlink belongs into the devel sub-package.
Please include AUTHORS and ChangeLog as documentation.
Commonly the %package and %description sections are all before the prep
section.
The group seems wrong to me, as this is no application.
You've got two percent signs in from of description devel!
rm -rf $RPM_BUILD_ROOT is obsolete and can be removed.
These should be fixed right now.
Your build appends -O3 to the Fedora flags. To my knowledge, that
results in
O3 being used.
I have sent this request to upstream developer.
Use the name and version macro in Source0 and potentially in the
files
section.
The URL (in Source 0) depends also on pgfoundry release_id. I am not sure if is
good practice to use here this macro, because you can get wrong url afterwards.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=REtqMXCgsl&a=cc_unsubscribe