https://bugzilla.redhat.com/show_bug.cgi?id=2169238
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ngompa13(a)gmail.com
--- Comment #2 from Neal Gompa <ngompa13(a)gmail.com> ---
Spec review:
desktop-file-validate
%{buildroot}%{_datadir}/applications/%{app_id}.desktop
appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{app_id}.appdata.xml
Nit: These should be in %check so that it's obvious they're part of package
verification
%{python3_sitelib}/%{name}
Please add a trailing slash so that it's obvious the RPM that this is a
directory.
%{_datadir}/icons/hicolor/*/*/%{app_id}*
This means we need "Requires: hicolor-icon-theme" in the package.
%{_datadir}/%{name}
Please add a trailing slash so that it's obvious the RPM that this is a
directory.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169238