https://bugzilla.redhat.com/show_bug.cgi?id=2035544
Bug ID: 2035544 Summary: Review Request: rust-coolor - Conversion between color formats Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-coolor/rust-coolor.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-coolor/rust-coolor-0.3.1-1.fc3...
Description: Conversion between color formats.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=80420714
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2035546
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2035546 [Bug 2035546] Review Request: rust-termimad - Markdown Renderer for the Terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |POST
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
Note: There's some image files in /doc and the bacon.toml file that might not be necessary, or a good idea to ship in the -devel package.
I recommend you either add an 'exclude = ["/doc", "/bacon.toml"]' line to Cargo.toml with your patch as well, or add an %exclude to the -devel package's %files list for them.
===
Recommended post-import rust-sig tasks:
- add package to rust-sig with "commit" access
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
--- Comment #4 from Davide Cavalca dcavalca@fb.com --- Thanks!
$ fedpkg request-repo rust-coolor 2035544 https://pagure.io/releng/fedora-scm-requests/issue/40334
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-coolor
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b5210812ea has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b5210812ea
https://bugzilla.redhat.com/show_bug.cgi?id=2035544
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-01-05 10:15:01
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b5210812ea has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org