https://bugzilla.redhat.com/show_bug.cgi?id=1344249
--- Comment #1 from Adam Miller <admiller(a)redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#macros
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (unversioned/unknown version)", "GPL (v3 or later)",
"Unknown or generated". 82 files have unknown license. Detailed output
of licensecheck in
/home/admiller/reviews/1344249-libtaskotron/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/libtaskotron
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/libtaskotron
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/taskotron/namespaces.yaml %config
/etc/taskotron/yumrepoinfo.conf
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
http://qadevel.fedoraproject.org/releases/libtaskotron/libtaskotron-0.4.1...
See:
http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libtaskotron-core , libtaskotron-config , libtaskotron-fedora ,
libtaskotron-disposable
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: libtaskotron-0.4.13-2.fc23.noarch.rpm
libtaskotron-core-0.4.13-2.fc23.noarch.rpm
libtaskotron-config-0.4.13-2.fc23.noarch.rpm
libtaskotron-fedora-0.4.13-2.fc23.noarch.rpm
libtaskotron-disposable-0.4.13-2.fc23.noarch.rpm
libtaskotron-0.4.13-2.fc23.src.rpm
libtaskotron.noarch: W: spelling-error Summary(en_US) Taskotron -> Astronaut
libtaskotron.noarch: W: spelling-error %description -l en_US taskotron ->
astronaut
libtaskotron.noarch: W: no-documentation
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron/images
taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron/images
2775
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron/artifacts
taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron/artifacts
2775
libtaskotron-core.noarch: W: non-standard-gid /var/log/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/log/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/tmp/taskotron taskotron
libtaskotron-core.noarch: E: dir-or-file-in-var-tmp /var/tmp/taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/tmp/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/cache/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/cache/taskotron 2775
libtaskotron-core.noarch: W: log-files-without-logrotate ['/var/log/taskotron']
libtaskotron-core.noarch: W: no-manual-page-for-binary runtask
libtaskotron-config.noarch: W: conffile-without-noreplace-flag
/etc/taskotron/yumrepoinfo.conf
libtaskotron-config.noarch: W: conffile-without-noreplace-flag
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: W: no-documentation
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/yumrepoinfo.conf
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/yumrepoinfo.conf
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/taskotron.yaml
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/taskotron.yaml
libtaskotron-fedora.noarch: W: no-documentation
libtaskotron-disposable.noarch: W: summary-not-capitalized C disposable client
module for libtaskotron
libtaskotron-disposable.noarch: W: no-documentation
libtaskotron.src: W: spelling-error Summary(en_US) Taskotron -> Astronaut
libtaskotron.src: W: spelling-error %description -l en_US taskotron ->
astronaut
libtaskotron.src:228: W: macro-in-%changelog %files
libtaskotron.src:348: W: macro-in-%changelog %check
libtaskotron.src: W: invalid-url Source0:
http://qadevel.fedoraproject.org/releases/libtaskotron/libtaskotron-0.4.1...
<urlopen error [Errno -5] No address associated with hostname>
6 packages and 0 specfiles checked; 13 errors, 22 warnings.
Rpmlint (installed packages)
----------------------------
libtaskotron-disposable.noarch: W: summary-not-capitalized C disposable client
module for libtaskotron
libtaskotron-disposable.noarch: W: no-documentation
libtaskotron-config.noarch: W: conffile-without-noreplace-flag
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: W: conffile-without-noreplace-flag
/etc/taskotron/yumrepoinfo.conf
libtaskotron-config.noarch: W: no-documentation
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/taskotron.yaml
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/taskotron.yaml
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/namespaces.yaml
libtaskotron-config.noarch: E: executable-marked-as-config-file
/etc/taskotron/yumrepoinfo.conf
libtaskotron-config.noarch: E: script-without-shebang
/etc/taskotron/yumrepoinfo.conf
libtaskotron.noarch: W: no-documentation
libtaskotron-core.noarch: W: non-standard-gid /var/log/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/log/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron/artifacts
taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron/artifacts
2775
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron/images
taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron/images
2775
libtaskotron-core.noarch: W: non-standard-gid /var/lib/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/lib/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/tmp/taskotron taskotron
libtaskotron-core.noarch: E: dir-or-file-in-var-tmp /var/tmp/taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/tmp/taskotron 2775
libtaskotron-core.noarch: W: non-standard-gid /var/cache/taskotron taskotron
libtaskotron-core.noarch: E: non-standard-dir-perm /var/cache/taskotron 2775
libtaskotron-core.noarch: W: log-files-without-logrotate ['/var/log/taskotron']
libtaskotron-core.noarch: W: no-manual-page-for-binary runtask
libtaskotron-fedora.noarch: W: no-documentation
5 packages and 0 specfiles checked; 13 errors, 15 warnings.
Requires
--------
libtaskotron-disposable (rpmlib, GLIBC filtered):
libtaskotron-core
python(abi)
python-paramiko
testcloud
libtaskotron-config (rpmlib, GLIBC filtered):
config(libtaskotron-config)
libtaskotron (rpmlib, GLIBC filtered):
/bin/sh
libtaskotron-config
libtaskotron-core
libtaskotron-disposable
libtaskotron-fedora
libtaskotron-core (rpmlib, GLIBC filtered):
/usr/bin/python
PyYAML
libtaskotron-config
python(abi)
python-configparser
python-jinja2
python-progressbar
python-requests
python-resultsdb_api
python-setuptools
libtaskotron-fedora (rpmlib, GLIBC filtered):
createrepo
dnf
koji
libtaskotron-core
mash
python(abi)
python-fedora
python-hawkey
python-munch
rpm-python
Provides
--------
libtaskotron-disposable:
libtaskotron-disposable
libtaskotron-config:
config(libtaskotron-config)
libtaskotron-config
libtaskotron:
libtaskotron
libtaskotron-core:
libtaskotron-core
libtaskotron-fedora:
libtaskotron-fedora
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1344249
Buildroot used: fedora-23-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
NOTES
-----
Please fix:
- Download URL for Source0
- rpmlint complaint about executable conf files
- rpmlint complaint about conf file not noreplace
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component