Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: collada-dom - COLLADA Document Object Model Library
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Summary: Review Request: collada-dom - COLLADA Document Object Model Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tim@niemueller.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~timn/misc/collada-dom.spec SRPM URL: http://fedorapeople.org/~timn/misc/collada-dom-2.3-1.fc14.src.rpm Description: COLLADA is a royalty-free XML schema that enables digital asset exchange within the interactive 3D industry. The COLLADA Document Object Model (COLLADA DOM) is an application programming interface (API) that provides a C++ object representation of a COLLADA XML instance document.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2928102
rpmlint: collada-dom.src: W: invalid-url Source0: collada-dom-2.3.tar.bz2 - No tarballs released by project (yet), instructions how to recreate tarball from svn in the spec comments. It is still a regular release, therefore the release part in the package version is "1" and not "0.1".
collada-dom-devel.x86_64: W: no-documentation - no documentation exists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Tim Niemueller tim@niemueller.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |674008
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #1 from Tim Niemueller tim@niemueller.de 2011-03-21 17:06:09 EDT --- New koji build, a dependency was wrong before (changed files in place): http://koji.fedoraproject.org/koji/taskinfo?taskID=2929514
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2011-03-22 07:54:04 EDT --- I'll review it
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2011-03-24 06:08:24 EDT --- REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent
work ~/Desktop: rpmlint collada-dom-* collada-dom.src: W: invalid-url Source0: collada-dom-2.3.tar.bz2 collada-dom-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. work ~/Desktop:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (MIT). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: diff -ru collada-dom-2.3 collada-dom-2.3-from-src.rpm/ sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. + The package stores shared library files in some of the dynamic linker's default paths, and it calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. + Header files are stored in a -devel package. 0 No static libraries. + The pkgconfig(.pc) files are stored in a -devel package and necessary runtime requirement added. + The library file(s) that end in .so (without suffix) is(are) stored in a -devel package. + The -devel package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Tim Niemueller tim@niemueller.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Tim Niemueller tim@niemueller.de 2011-03-24 06:38:20 EDT --- Thanks for the quick and thorough review.
New Package SCM Request ======================= Package Name: collada-dom Short Description: COLLADA Document Object Model Library Owners: timn Branches: f14 f15 el5 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2011-03-24 08:42:21 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-04-06 06:38:25 EDT --- collada-dom-2.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/collada-dom-2.3-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-04-06 06:39:44 EDT --- collada-dom-2.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/collada-dom-2.3-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-04-06 06:40:25 EDT --- collada-dom-2.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/collada-dom-2.3-2.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-04-06 18:34:53 EDT --- collada-dom-2.3-2.fc14 has been pushed to the Fedora 14 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-04-14 16:55:14 EDT --- collada-dom-2.3-2.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |collada-dom-2.3-2.fc14 Resolution| |ERRATA Last Closed| |2011-04-14 16:55:19
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-04-21 15:55:57 EDT --- collada-dom-2.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-06-02 06:56:21 EDT --- collada-dom-2.3-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689432
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-06-02 14:50:05 EDT --- collada-dom-2.3-2.fc15 has been pushed to the Fedora 15 stable repository.
package-review@lists.fedoraproject.org