Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: jflex-1.3.5-2jpp - Fast Scanner Generator
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227070
pcheung(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|pcheung(a)redhat.com |mwringe(a)redhat.com
Flag|fedora-review- |fedora-review+
------- Additional Comments From pcheung(a)redhat.com 2007-02-13 16:30 EST -------
(In reply to comment #4)
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > ...
> > > X correct buildroot
> > > - should be:
> > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> > done
> >
> Thanks.
> > > * if %{?dist} is used, it should be in that form (note the ? and %
> > > locations)
> There's an extra . before %{?dist}
Oops, fixed.
Great!
> > > X license text included in package and marked with
%doc
> > > COPYRIGHT missing from %doc
> > done
> >
> It's now in the doc subpackage, but I think it should stay in the main package
> with a %doc flag in the %files section.
There is no doc subpackage, the doc files are being marked with %doc in the main
package's %file section.
Sorry.. read it incorrectly earlier.
> > > ...
> > > X specfile is legible
> > > - Get rid of Vendor and Distribution tag
> > done
> >
> Thanks
> > > - Source0 should be:
http://downloads.sourceforge.net/jflex/jflex-1.3.5.tar.gz
> > done
> Thanks
> >
> > > - Fix release 2jpp.1%{?dist}
> > done
> >
> Please note no . after 1.
> > > ...
> > > X make sure lines are <= 80 characters
> > > line 89 is longer than 80 characters
> > done
> >
> Great
> > >...
> > > * run rpmlint on the binary RPMs
> > > W: jflex non-standard-group Development/Libraries/Java
> > > W: jflex wrong-file-end-of-line-encoding
/usr/share/doc/jflex-1.3.5/COPYRIGHT
> > > W: jflex uncompressed-zip
/usr/share/java/jflex-1.3.5.jar
> > > W: jflex-javadoc non-standard-group Development/Documentation
> > > W: jflex-javadoc dangerous-command-in-%post rm
> > > W: jflex-javadoc dangerous-command-in-%postun rm
> > No warnings or errors other than about groups (which can be safely ignored)
> >
> > New spec file can be found here:
> >
https://mwringe.108.redhat.com/files/documents/175/209/jflex.spec
> >
> > New srpm can be found here:
> >
>
https://mwringe.108.redhat.com/files/documents/175/210/jflex-1.3.5-2jpp.1...
>
> rpmlint now gives:
> W: jflex non-standard-group Development/Libraries/Java
> W: jflex non-standard-group Development/Libraries/Java
> W: jflex incoherent-version-in-changelog 0:1.3.5-2jpp.1 0:1.3.5-2jpp.1.
> W: jflex uncompressed-zip /usr/share/java/jflex-1.3.5.jar
> W: jflex-javadoc non-standard-group Development/Documentation
hmm, not getting the uncompressed-zip on my version.
I'm not seeing this anymore as well.
The spec file and srpm has been updated to the same location
I've built it successfully in mock, rpmlint on the final src and binary rpms
gives:
[pcheung@to-fcjpp1 ~]$ rpmlint
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/jflex-1.3.5-2jpp.1.fc7.src.rpm
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/jflex-1.3.5-2jpp.1.fc7.noarch.rpm
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/jflex-javadoc-1.3.5-2jpp.1.fc7.noarch.rpm
W: jflex non-standard-group Development/Libraries/Java
W: jflex non-standard-group Development/Libraries/Java
W: jflex-javadoc non-standard-group Development/Documentation
APPROVED. Thanks!
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.