Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961384
Bug ID: 961384 Summary: Review Request: vim-javabrowser - JavaBrowser plugin for VIM Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: phracek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Category: ---
Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-1.fc18.... Description: This script is SPECIFICALLY tailored for Java language. So, it shows structure of the Java file starting with classes defined within it and NOT in a general tag structure. I found it useful and hope you all find it useful too. It also has a nice syntax to show the class members in UML format. Fedora Account System Username: phracek
$ rpmlint vim-javabrowser.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/phracek/rpmbuild/SRPMS/vim-javabrowser-2.03-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sochotni@redhat.com
--- Comment #1 from Stanislav Ochotnicky sochotni@redhat.com --- Not doing a full review, just a few comments: * missing description * Group tag is not really used/needed anymore * Why do you need Requires(post[un]): vim? There are no post[un] scriptlets * %defattr macro is not needed either
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #2 from Petr Hracek phracek@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-2.fc18....
Issues where fixed
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuska@redhat.com Assignee|nobody@fedoraproject.org |rkuska@redhat.com Flags| |fedora-review?
--- Comment #3 from Robert Kuska rkuska@redhat.com --- I'll take this for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #4 from Robert Kuska rkuska@redhat.com --- You forgot to remove %defattr macro.
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #5 from Petr Hracek phracek@redhat.com --- Thanks,
%defattr macro was removed: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc18....
~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/RPMS/noarch/vim-javabrowser-2.03-3.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/SRPMS/vim-javabrowser-2.03-3.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser>
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #6 from Robert Kuska rkuska@redhat.com --- The requested URL /vim-javabrowser/vim-javabrowser-2.03-3.fc18.src.rpm was not found on this server. Please fix that so I can use fedora-review tool.
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #7 from Petr Hracek phracek@redhat.com --- I upgraded OS to Fedora 19.
Correct URLs are: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc19....
Copy paste error:(
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from Robert Kuska rkuska@redhat.com --- Looks good now, approved.
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Petr Hracek phracek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Petr Hracek phracek@redhat.com --- New Package SCM Request ======================= Package Name: vim-javabrowser Short Description: JavaBrowser plugin for VIM Owners: phracek Branches: f19
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Petr Hracek phracek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Fixed In Version| |vim-javabrowser-2.03-3.fc20 Resolution|--- |RAWHIDE Last Closed| |2013-07-15 10:41:14
--- Comment #11 from Petr Hracek phracek@redhat.com --- scm-commit (https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130715/1...) -> CLOSED RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=961384
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- vim-javabrowser-2.03-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vim-javabrowser-2.03-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=961384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|vim-javabrowser-2.03-3.fc20 |vim-javabrowser-2.03-3.fc19 Resolution|RAWHIDE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- vim-javabrowser-2.03-3.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org