https://bugzilla.redhat.com/show_bug.cgi?id=996311
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-CAD-Format-STL.spec.old 2013-08-13 20:53:41.000000000 +0200
+++ perl-CAD-Format-STL.spec 2013-10-17 02:08:27.000000000 +0200
@@ -1,29 +1,32 @@
# Declare the CPAN name of the module
%define mod_basename CAD-Format-STL
+# RPM's auto require for perl(Class::Accessor::Classy) fails, handle manually
+%define __requires_exclude ^perl\\(Class::Accessor::Classy\\)$
Name: perl-%{mod_basename}
Version: 0.2.1
-Release: 3%{?dist}
-Summary: Read and Write STL (STereoLithography) format files
+Release: 4%{?dist}
+Summary: Read and Write STL (STereo Lithography) format files
License: GPL+ or Artistic
Group: Development/Libraries
URL:
http://search.cpan.org/dist/%{mod_basename}/
Source:
http://www.cpan.org/modules/by-module/CAD/%{mod_basename}-v%{version}.tar.gz
BuildArch: noarch
-BuildRequires: perl
BuildRequires: perl(strict)
BuildRequires: perl(warnings)
BuildRequires: perl(Carp)
-BuildRequires: perl(Class::Accessor::Classy) >= v0.1.3
-BuildRequires: perl(Module::Build)
+BuildRequires: perl(Class::Accessor::Classy) >= 0.1.3
+BuildRequires: perl(Module::Build) >= 0.35
# These are needed for "Build test"
+BuildRequires: perl(bytes)
BuildRequires: perl(Test::More)
+Requires: perl(bytes)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
-Requires: perl(Class::Accessor::Classy) >= v0.1.3
+Requires: perl(Class::Accessor::Classy) >= 0.1.3
%description
The CAD::Format::STL perl module provides object-oriented methods to read
-and write files in STL (STereoLithography) format. Support is provided
+and write files in STL (STereo Lithography) format. Support is provided
for both the ASCII and binary versions of the STL format.
%prep
@@ -31,7 +34,7 @@
%build
# Using Module::Build since a Build.PL is present
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
./Build
%install
@@ -50,14 +53,19 @@
%endif
%files
-%if 0%{?rhel} && 0%{?rhel} < 6
-%defattr(-,root,root,-)
-%endif
%doc files Changes README
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Wed Oct 16 2013 John C. Peterson <jcp(a)eskimo.com> 0.2.1-4
+- Various fixes that were required or suggested by the package reviewer:
+ Added the package's version number build requirement for perl(Module::Build)
+ Added filter rule for rpm's auto require of perl(Class::Accessor::Classy)
+ Added perl(bytes) to both the build and runtime requirements
+ Removed the redundant defattr macro from the files section
+ Replaced the __perl macro with just perl in the build section
+
* Tue Aug 13 2013 John C. Peterson <jcp(a)eskimo.com> 0.2.1-3
- Some cosmetic tweaks to the macros that check for the specific case of RHEL.
TODO: You can replace the `%{__perl}' macro with plain
`perl'.
TODO: You can do the same at perl(:MODULE_COMPAT_*) definition.
TODO: You can remove the deffattr macro completely, because even
EPEL-5 has
rpm-4.4 where the macro is redundant.
-%if 0%{?rhel} && 0%{?rhel} < 6
-%defattr(-,root,root,-)
-%endif
Ok.
TODO: META.yml declares minimal Module::Build version 0.35. Make sure
your
package builds in EPEL-5 or add this constrain to the corresponding
BuildRequire tag.
-BuildRequires: perl(Module::Build)
+BuildRequires: perl(Module::Build) >= 0.35
Ok.
FIX: Remove `v' from `perl(Class::Accessor::Classy) >=
v0.1.3' dependency
declarations. See what perl-Class-Accessor-Classy package provides and how
RPM compares the versions (rpmdev-vercmp v0.1.3 0).
-BuildRequires:
perl(Class::Accessor::Classy) >= v0.1.3
+BuildRequires: perl(Class::Accessor::Classy) >= 0.1.3
Ok.
TODO: Build-require `perl(bytes)' (lib/CAD/Format/STL.pm:421).
+BuildRequires: perl(bytes)
Ok.
FIX: Remove `v' from `perl(Class::Accessor::Classy) >=
v0.1.3' dependency
declarations.
-Requires: perl(Class::Accessor::Classy) >= v0.1.3
+Requires: perl(Class::Accessor::Classy) >= 0.1.3
Ok.
TODO: Filter the under-specified dependency
`perl(Class::Accessor::Classy)'.
+# RPM's auto require for
perl(Class::Accessor::Classy) fails, handle manually
+%define __requires_exclude ^perl\\(Class::Accessor::Classy\\)$
Ok.
TODO: There is a convention to place the macro just before %description
section.
TODO: Run-require `perl(bytes)' (lib/CAD/Format/STL.pm:421).
+Requires: perl(bytes)
Ok.
$ rpmlint perl-CAD-Format-STL.spec
../SRPMS/perl-CAD-Format-STL-0.2.1-4.fc21.src.rpm
../RPMS/noarch/perl-CAD-Format-STL-0.2.1-4.fc21.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is OPk.
$ rpm -q --requires -p
../RPMS/noarch/perl-CAD-Format-STL-0.2.1-4.fc21.noarch.rpm | sort -i | uniq -c
1 perl(:MODULE_COMPAT_5.18.1)
1 perl(CAD::Format::STL::part)
1 perl(Carp)
1 perl(Class::Accessor::Classy) >= 0.1.3
1 perl(bytes)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-CAD-Format-STL-0.2.1-4.fc21.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F21
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=6069570). Ok.
Package is good.
Please consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.