https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Bug ID: 2022205 Summary: Review Request: rust-unic-langid-macros - API for managing Unicode Language Identifiers Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: link@sub-pop.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Description: API for managing Unicode Language Identifiers Fedora Account System Username: linkdupont Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ngompa13@gmail.com Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Package was generated through rust2rpm, simplifying the review considerably.
- Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unic-langid-macros
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #5 from Fabio Valentini decathorpe@gmail.com ---
- only sources installed
This is not true. The package installs two binaries (even though it was "turned off" by setting a dunder-macro).
Just overriding __cargo_skip_build is the wrong thing to do here (as is overriding double-underscored-macros, in general), because that also makes the package noarch, where it shouldn't be, so tests only run on one architecture at a time, etc.
Additionally, this unconventional use of "__cargo_skip_build 1" is now broken, because that macro was under no circumstances set to 1 since Fedora 31 or so (it was only ever set to 1 in module builds, and it's been a long while since those were a thing for Rust).
Since it looks like those binaries are only used for upstream development, I suggest to drop them from the .spec file entirely to prevent future issues like this. You can look at https://src.fedoraproject.org/rpms/rust-protobuf-codegen-pure/tree/rawhide for an example how to do that relatively easily (rust2rpm will not even generate the subpackages related to binaries if you do it like this).
Another way to do this (that's not as nice) is to set the __cargo_is_bin() macro to 0 and drop the generated binary subpackage manually, like in cargo: https://src.fedoraproject.org/rpms/rust-cargo/blob/rawhide/f/rust-cargo.spec
But the first solution (small patch to disable building the binaries) is a cleaner solution, as that also automatically adapts the generated .spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Oh, sorry, I commented on the wrong bug, this should've been on the rust-unic-langid-impl review request, instead.
PS: You can see that the package now fails to build because it relies on the "__cargo_skip_build" implementation detail, which was removed with rust2rpm 20: https://koschei.fedoraproject.org/package/rust-unic-langid-impl?collection=f...
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022205 Bug 2022205 depends on bug 2009923, which changed state.
Bug 2009923 Summary: Review Request: rust-tinystr - Small ASCII-only bounded length string representation https://bugzilla.redhat.com/show_bug.cgi?id=2009923
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2022205 Bug 2022205 depends on bug 2022204, which changed state.
Bug 2022204 Summary: Review Request: rust-unic-locale-impl - API for managing Unicode Locale Identifiers https://bugzilla.redhat.com/show_bug.cgi?id=2022204
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2022205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-12-11 01:30:36
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2022205 Bug 2022205 depends on bug 2022206, which changed state.
Bug 2022206 Summary: Review Request: rust-unic-langid-macros-impl - API for managing Unicode Language Identifiers https://bugzilla.redhat.com/show_bug.cgi?id=2022206
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org