https://bugzilla.redhat.com/show_bug.cgi?id=2276949
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #9 from Fabio Valentini <decathorpe(a)gmail.com> ---
Looks good to me, thanks.
Can you replace this line:
%license LICENSE-APACHE LICENSE-MIT
With these two please?
%license %{crate_instdir}/LICENSE-APACHE
%license %{crate_instdir}/LICENSE-MIT
Otherwise the files will end up duplicated in the built package (once in
/usr/share/licenses/ and once in /usr/share/cargo/registry/).
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (some tests disabled with
explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files (included manually from
upstream git repo)
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on
release-monitoring.org:
project: $crate
homepage:
https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer
(should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches
(should happen automatically once rust-sig is co-maintainer)
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276949
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...