https://bugzilla.redhat.com/show_bug.cgi?id=1622685
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Tests fail:
4 passing (9ms)
3 failing
1) zeropad throws when num is NaN:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is
ambiguous. The error message "zeropad requires a number or string" is identical
to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:32:16)
2) zeropad throws when length is NaN:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is
ambiguous. The error message "zeropad requires a positive integer for length"
is identical to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:38:16)
3) zeropad throws on negative length:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is
ambiguous. The error message "zeropad requires a positive integer for length"
is identical to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:44:16)
Node v10 has some additional assert sanity checks: if the thrown error message
text equals the assert function call's descriptive message text argument, it
reports this error. In order to fix this, you thus can change the message:
# Add tests to npm archive.
#
https://github.com/radiovisual/zeropad/pull/1
Source1:
https://raw.githubusercontent.com/radiovisual/zeropad/3bd15b69384cc74d55a...
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package approved. Please fix the tests above before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component