Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
Summary: Review Request: gfs-utils - global file system userland utilities Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: cfeist@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/cfeist/gfs-utils.spec SRPM URL: http://people.redhat.com/cfeist/gfs-utils-0.1.0-0.fc6.0.src.rpm Description: This package provides the userland utilities for GFS (Global File System) version 1. mkfs, fsck, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From rc040203@freenet.de 2006-07-14 04:16 EST ------- You spec contains this:
if ["$1" = 0 ]; then
This is invalid /bin/sh syntax. There must be a blank after the '['.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From cfeist@redhat.com 2006-07-14 11:46 EST ------- Thanks, this has been fixed.
New files are here:
http://people.redhat.com/cfeist/gfs-utils.spec http://people.redhat.com/cfeist/gfs-utils-0.1.0-0.fc6.1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From panemade@gmail.com 2006-07-15 02:53 EST ------- Mock build failed for rawhide i386 main.c:29:26: error: libvolume_id.h: No such file or directory
You Need to add libvolume_id-devel in BuildRequires
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From cfeist@redhat.com 2006-07-17 15:12 EST ------- Fixed that as well. (libvolume_id.h BuildRequire)
New files are here: http://people.redhat.com/cfeist/gfs-utils.spec http://people.redhat.com/cfeist/gfs-utils-0.1.0-0.fc6.2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From tibbs@math.uh.edu 2006-07-20 22:47 EST ------- Chris, I don't see you in the cvsextras group. Do you require sponsorship? See http://fedoraproject.org/wiki/Extras/HowToGetSponsored for more information.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From cfeist@redhat.com 2006-09-29 16:14 EST ------- Jason,
Yes I do need sponsorship for this package. Can you sponsor me?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@math.uh.edu OtherBugsDependingO| |177841 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-09-29 18:01 EST ------- I can, but would need to look over this and your other submissions first. I hope to have some time to spend on extras reviews over the next couple of days.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |ruben@rubenkerkhof.com OtherBugsDependingO|163776, 177841 |163778 nThis| |
------- Additional Comments From ruben@rubenkerkhof.com 2007-01-22 18:11 EST ------- Hi Chris,
Since you've been sponsored by jkatz, I'll remove the FE-NEEDSPONSOR blocker.
I've found a few things though:
rpmlint of gfs-utils is not silent: W: gfs-utils incoherent-version-in-changelog 0.1.0-0.fc6.0 0.1.0-0.fc6.2 W: gfs-utils service-default-enabled /etc/rc.d/init.d/gfs E: gfs-utils missing-mandatory-lsb-tag Description E: gfs-utils missing-mandatory-lsb-tag Short-Description W: gfs-utils incoherent-init-script-name gfs
The package should contain the text of the license (wiki: Packaging/ReviewGuidelines)
Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets) Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)
* Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * No downloadable source. Please give the full URL in the Source tag.
Please don't hardcode the distro in Release, use %dist
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From ruben@rubenkerkhof.com 2007-02-03 16:29 EST ------- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From cfeist@redhat.com 2007-02-21 16:51 EST ------- I've updated the package. I don't know what 'missing-mandatory-lsb-tag' means and can't find any documentation on how to fix those errors. All other errors should be fixed. There is no central location for the gfs-utils-0.1.11.tar.gz script, it's pulled directly out of cvs which is found at sources.redhat.com/cluster/
http://people.redhat.com/cfeist/gfs-utils-0.1.11-3.src.rpm
Let me know what else I need for this rpm.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From ruben@rubenkerkhof.com 2007-02-21 18:19 EST ------- Thanks Chris,
E: gfs-utils missing-mandatory-lsb-tag Description E: gfs-utils missing-mandatory-lsb-tag Short-Description
Those errors are about the init file rpmlint checks that file for tags between
### BEGIN INIT INFO
and
### END INIT INFO
The checks are defined in /usr/share/rpmlint/InitScriptCheck.py
A few new rpmlint warnings have popped up:
[ruben@odin i386]$ rpmlint gfs-utils-0.1.11-3.i386.rpm W: gfs-utils dangling-relative-symlink /sbin/mount.gfs mount.gfs2 W: gfs-utils dangling-relative-symlink /sbin/umount.gfs umount.gfs2
[ruben@odin i386]$ rpmlint gfs-utils-debuginfo-0.1.11-3.i386.rpm W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/log.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_dir.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/util.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/inode.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_bits.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/rgrp.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/file.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_bmap.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/bitmap.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_inode.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/block_list.c W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/bio.c
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
------- Additional Comments From ruben@rubenkerkhof.com 2007-03-23 04:07 EST ------- Hi Chris,
Please respond, or I'll have to close this ticket in a week.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-utils - global file system userland utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NOTABUG OtherBugsDependingO|163778 |201449 nThis| |
------- Additional Comments From ruben@rubenkerkhof.com 2007-04-04 17:15 EST ------- Sorry, I'll have to close this review.
package-review@lists.fedoraproject.org