https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Bug ID: 1899776 Summary: Review Request: python-volatile - A small extension for the tempfile module Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/python/python-volatile.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python-volatile-2.1.0-1.fc33.s... Description: Temporary files and directories.
Contains replacement for tempfile.NamedTemporaryFile that does not delete the file on close(), but still unlinks it after the context manager ends, as well as a mkdtemp-based temporary directory implementation.
- Mostly reuses the stdlib implementations, supporting the same signatures. - Due to that, uses the OS’s built-in temporary file facilities, no custom schemes. - Tested on Python 2.6+ and 3.3+
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1899777
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1899777 [Bug 1899777] Review Request: python-moreorless - Python diff wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1899779
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1899779 [Bug 1899779] Review Request: python-bowler - Safe code refactoring for modern Python projects
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package is properly named per Packaging Guidelines * Package builds and installs correctly * Packaging follows Python Packaging Guidelines * Package does not include a license file
Michel, could you switch to just pulling the release from GitHub instead of PyPI? That way, you'd have a license file. Alternatively, you can do something like what python-trololio does to get the license file included[1].
[1]: https://src.fedoraproject.org/rpms/python-trololio/blob/master/f/python-trol...
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- yeah, let me try doing that.
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Spec URL: https://salimma.fedorapeople.org/specs/python/python-volatile.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python-volatile-2.1.0-2.fc33.s...
using GitHub source tarball, which includes the license text
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- Looks good to me!
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
❯ fedpkg request-repo python-volatile 1899776 https://pagure.io/releng/fedora-scm-requests/issue/30819
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-volatile
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-8824979bf1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8824979bf1 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-96fc0244e0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-96fc0244e0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-11-29 01:14:03
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1899776
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org