https://bugzilla.redhat.com/show_bug.cgi?id=1479027
--- Comment #11 from Athos Ribeiro <athoscribeiro(a)gmail.com> ---
(In reply to Fabio Valentini from comment #10)
1) There are some minor typos / spelling errors which you might want
to
correct (line 44: provite->provide, line 275: skiping-> skipping).
Fixed
2) Since you are packaging this go library for two import paths, I
guess
that both are used by dependencies. In this case, using two -devel
subpackages seems reasonable.
OK
3) There are some empty conditionals leftover from the gofed template. You
can leave them in with comments that they might be needed one day, or just
remove them.
I learned it is better to keep those to reduce the diff if I ever need to
re-generate the spec with gofed
4) "%global devel_prefix x" this isn't needed
anywhere.
Fixed: removed the global.
5) It looks like most/all of the testdata is listed in %files
sections
multiple times ("warning: File listed twice:" warnings in the koji build
logs). You might want to look at the %install script to find out how this
happens.
Fixed, thanks for catching that!
Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-golang-image-0-0...
Koji Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21250259
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component