Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-pango - Ruby binding of pango-1.x
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Summary: Review Request: rubygem-pango - Ruby binding of pango-1.x Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango.s... SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango-0... Description: Ruby/Pango is a Ruby binding of pango-1.x.
Depending on bug 635302, bug 637448 and rubygem-test-unit (still in testing), so currently scratch build on koji is not available. Mock rebuild log for F-14 is available on: http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/MOCK-rubygem-pa...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |635302, 637448
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-30 13:42:01 EDT --- http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango.s... http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango-0...
* Fri Oct 1 2010 Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp - 0.90.2-4 - Use formally released gem file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-30 14:16:06 EDT --- http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango.s... http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango-0...
* Fri Oct 1 2010 Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp - 0.90.2-5 - Fix up summary - Fix Requires for -devel subpackage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |639098
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@redhat.com QAContact|extras-qa@fedoraproject.org |mfojtik@redhat.com Flag| |fedora-review?
--- Comment #3 from Michal Fojtik mfojtik@redhat.com 2010-10-11 09:47:30 EDT --- Review:
[OK] First, %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled.
[OK] Then at %build stage the Ruby Gem must be installed under the directory created at %prep stage to get C libraries compiled under there.
[OK] When gem install is used to install Gem file, using -V option is recommend to check if CFLAGS is correctly honored.
[OK] Finally at %install stage the whole tree under the directory created at %prep stage should be copied (not moved) to under %{buildroot}%{gemdir}.
[OK] When all tree under the directory created at %prep stage is moved to under %{buildroot}, find_debuginfo.sh will complain that the corresponding source files are missing.
[OK] Installed C codes (usually under %{geminstdir}/etc) may be removed even if gem contents %{gemname} reports that installed C codes should be found there.
Unfortunately, I can't build this package because of missing rubygem-cairo-devel (which is already packaged and waiting in testing I suppose):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2527617
Anyway, spec file looks good enough to me. REVIEW+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-11 12:18:15 EDT --- Thank you!
New Package SCM Request ======================= Package Name: rubygem-pango Short Description: Ruby binding of pango-1.x Owners: mtasaka Branches: f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2010-10-11 14:28:21 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mfojtik@redhat.com QAContact|mfojtik@redhat.com |extras-qa@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-12 06:46:02 EDT --- Built on F-13/14, push requested on bodhi:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Bug 637985 depends on bug 635302, which changed state.
Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo https://bugzilla.redhat.com/show_bug.cgi?id=635302
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ON_QA |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Bug 637985 depends on bug 637448, which changed state.
Bug 637448 Summary: Review Request: rubygem-glib2 - Ruby binding of GLib-2.x https://bugzilla.redhat.com/show_bug.cgi?id=637448
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ON_QA |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637985
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-10-24 15:07:52
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-24 15:07:52 EDT --- Closing as now available on rawhide
package-review@lists.fedoraproject.org