Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

cheekyboinc@foresightlinux.org changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From cheekyboinc@foresightlinux.org 2008-06-06 21:01 EST ------- Thank you Hemant for your feedback! Here is my new version.

Spec URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/ fbpanel.spec SRPM URL: http://files.spielen-unter-linux.de/repository/fedora/9/SRPMS/ fbpanel-4.12-2.fc9.src.rpm

Changelog: - fixed rpmlint errors, new .desktop file, cleanup

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-15 10:03 EST ------- The srpm on comment 3 does not build.

http://koji.fedoraproject.org/koji/taskinfo?taskID=662736

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From redhat-bugzilla@linuxnetz.de 2008-06-15 10:27 EST ------- Oh, I forgot: This doesn't solve /usr/lib vs. /usr/lib64 anyway.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From cheekyboinc@foresightlinux.org 2008-06-15 15:49 EST ------- SPEC: http://cheekyboinc.spielen-unter-linux.de/fbpanel.spec SRPM: http://cheekyboinc.spielen-unter-linux.de/fbpanel-4.12-3.fc9.src.rpm

Changelog:

- Solved build failure and broken libs-patch with patch from Robert Scheck

Thank you Robert and Mamoru for your feedback!

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-16 15:09 EST ------- For 4.12-3:

* License - Well, actually I cannot understand why the upstream ships MIT license text... ------------------------------------------------------------ bg.c LGPLv2+ bg.h LGPLv2+ ev.c LGPLv2+ ev.h LGPLv2+ gtkbar.c LGPLv2+ gtkbar.h LGPLv2+ gtkbgbox.c LGPLv2+ gtkbgbox.h LGPLv2+ plugins/cpu.c GPLv2+ plugins/pager.c GPLv2+ systray/eggtraymanager.c LGPLv2+ systray/eggtraymanager.h LGPLv2+ systray/fixedtip.c GPLv2+ systray/fixedtip.h GPLv2+ ------------------------------------------------------------ I have not analysed how these codes are used/linked yet, however from a quick glance, the license tag must be ------------------------------------------------------------ Group: User Interface/Desktops # %%{_bindir}/fbpanel and almost all plugins are under LGPLv2+ # Some plugins (cpu.so, pager.so, tray.so) are under GPLv2+ License: LGPLv2+ and GPLv2+ URL: http://fbpanel.sourceforge.net ------------------------------------------------------------

* SourceURL http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge - Please follow above.

* SOURCE2 - Write the full URL of SOURCE2, or write as a comment how you received Source2.

* Redundant BuildRequires - gtk2-devel Requires atk-devel, pango-devel, cairo-devel so all these 3 BuildRequires are redundant.

* Timestamp - When using "cp" or "install" commands, add "-p" option to keep timestamps on installed files, like ------------------------------------------------------------ install -p -m 0644 %{SOURCE2} \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps ------------------------------------------------------------

- Also, as this package installs many image files and so on which are actually not modified during build, keeping timestamps on those files are also perferred. To do so, please consider to use below: ------------------------------------------------------------ sed -i.stamp -e 's|install -m|install -p -m|' \ Makefile */Makefile ------------------------------------------------------------ at %prep stage.

* Debuginfo rpm missing - rpmlint complains about debuginfo rpm as below: ------------------------------------------------------------ fbpanel-debuginfo.i386: E: empty-debuginfo-package ------------------------------------------------------------ debuginfo rpm is not created correctly. Several reasons are related to this. * Fedora specific compilation flags are not honored correctly. Check: http://fedoraproject.org/wiki/Packaging/Guidelines#CompilerFlags ! To check if compiler flags are correctly honored, please make build log more verbosely. The outputs like ------------------------------------------------------------ 74 CC systray/eggtraymanager.o 75 DEP plugins/space.dep 76 DEP plugins/pager.dep 77 DEP plugins/launchbar.dep 78 CC systray/fixedtip.o 79 CC plugin.o 80 CC gtkbar.o ------------------------------------------------------------ is not useful. * Makefile "strip" binaries to be installed. /usr/lib/rpm/find-debuginfo.sh strips installed binaries correctly and Makefiles themselves must not strip binaries. * Installed plugin objects has 0644 permission. As these objects are dlopened so these should work, however as find-debuginfo.sh strips binaries only with executable permissions, on Fedora these must have 0755 permission.

The following will fix these 4 issues (please check what these changes actually do) ------------------------------------------------------------- %prep %setup -q %patch -p1 -b .libdir sed -i.strip -e 's|strip|true strip|' \ Makefile */Makefile sed -i.stamp -e 's|install -m|install -p -m|' \ Makefile */Makefile

%build ./configure --prefix=%{_prefix} --libdir=%{_lib} make \ %{?_smp_mflags} \ Q= \ CFLAGS="${RPM_OPT_FLAGS}"

%install rm -rf $RPM_BUILD_ROOT make install PREFIX=$RPM_BUILD_ROOT%{_prefix} ....... ....... install -p -m 0644 %{SOURCE2} \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps

find $RPM_BUILD_ROOT%{_libdir}/%{name} -name *.so -print0 | \ xargs -0 chmod 0755

%clean ....... -------------------------------------------------------------

* /sbin/ldconfig call - Calling /sbin/ldconfig on scriptlets is not needed for this package as no "libraries" are installed under default ldconfig paths.

* Icon cache update - As icons are installed under %_datadir/icons/hicolor, please follow http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-17 13:46 EST ------- For 4.12-4:

* License analysis - Please also write license analysis I wrote on comment 10 as comments in the spec file.

* Again Source2: -------------------------------------------------------- # image taken from the fbpanel source /config/images/star.png Source2: %{name}.png -------------------------------------------------------- - Okay, then you don't have to add this file seperately to srpm. The following will be enough. -------------------------------------------------------- install -p -m 0644 config/images/star.png \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/128x128/apps/%{name}.png -------------------------------------------------------- ! Note: This file has 128x128 size, not 32x32.

Then: ------------------------------------------------------------- NOTE: Before being sponsored:

This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you.

Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review)

When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review")

Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-18 05:29 EST ------- Okay.

+ This package itself is good now + Your anothre review request seems good to some extent at a quick glance.

---------------------------------------------------------------- This package (fbpanel) is APPOVED by me ----------------------------------------------------------------

Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". At a point a mail should be sent to sponsor members which notifies that you need a sponsor. At the stage, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-18 08:19 EST ------- Now I am sponsoring you. please follow "Join" wiki again.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-06-18 20:30 EST ------- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From updates@fedoraproject.org 2008-06-19 12:53 EST ------- fbpanel-4.12-5.fc8 has been submitted as an update for Fedora 8

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From updates@fedoraproject.org 2008-06-20 15:12 EST ------- fbpanel-4.12-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fbpanel - a lightweight X11 desktop panel

https://bugzilla.redhat.com/show_bug.cgi?id=448292

------- Additional Comments From updates@fedoraproject.org 2008-06-20 15:14 EST ------- fbpanel-4.12-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=448292

--- Comment #25 from Jon Ciesla limburgher@gmail.com 2012-04-05 08:08:40 EDT --- Git done (by process-git-requests).