https://bugzilla.redhat.com/show_bug.cgi?id=1766137
Bug ID: 1766137 Summary: Review Request: libcorrect - C library for Convolutional codes and Reed-Solomon Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/RussianFedora/libcorrect/master/libcorrect... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6000/38616000/libcorrect-0-1....
Description: It is a library for Forward Error Correction. By using libcorrect, extra redundancy can be encoded into a packet of data and then be sent across a lossy channel. When the packet is received, it can be decoded to recover the original, pre-encoded data.
https://bugzilla.redhat.com/show_bug.cgi?id=1766137
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/RussianFedora/libcorrect/master/libcorrect... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3871/38643871/libcorrect-0-1....
Use ninja for build.
https://bugzilla.redhat.com/show_bug.cgi?id=1766137
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vitaly@easycoding.org Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Flags| |fedora-review?
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_libdir}/libcorrect.so.*
1. Not allowed anymore. You must use soversion to avoid accidental bump.
2. Missing %ninja_build -C %{_target_platform}.
https://bugzilla.redhat.com/show_bug.cgi?id=1766137
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Vitaly Zaitsev vitaly@easycoding.org --- There is nothing I can complain about. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1766137
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libcorrect
https://bugzilla.redhat.com/show_bug.cgi?id=1766137
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-10-29 21:58:34
package-review@lists.fedoraproject.org