https://bugzilla.redhat.com/show_bug.cgi?id=1678884
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
Url and Source addresses are Ok.
Source0 archive (SHA-256:
dd995df485f7334796d242efa277586d38d2544cace6ca0c3629a225df1e42d8) is original.
Ok.
Summary verified from Rsync.pm. Ok.
Description verified from Rsync.pm. Ok.
License verified from Rsync.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
TODO: You can add "NO_PERLLOCAL=1" to a "perl Makefile.PL" command and
replace
"make pure_install DESTDIR=$RPM_BUILD_ROOT" with a "%make_install"
macro.
TODO: Do not package META.json file. Those are metadata not needed at run-time
or already provided elsewhere.
TODO: Replace a "%{__perl}" macro with a "perl" command. A dummy
macros are
demoted by current guidelines
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros>.
TODO: Build-require "perl(:VERSION) >= 5.008" (Rsync.pm:15).
FIX: Build-require "perl(Config)" (Makefile.PL:5) or remove it from the
Makefile.PL (it's not used for anything).
All tests pass. Ok.
$ rpmlint perl-File-Rsync.spec ../SRPMS/perl-File-Rsync-0.49-1.fc30.src.rpm
../RPMS/noarch/perl-File-Rsync-0.49-1.fc30.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-File-Rsync-0.49-1.fc30.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 20 10:22
/usr/share/doc/perl-File-Rsync
-rw-r--r-- 1 root root 23979 Mar 10 2016
/usr/share/doc/perl-File-Rsync/Changelog
-rw-r--r-- 1 root root 1055 Mar 10 2016
/usr/share/doc/perl-File-Rsync/META.json
-rw-r--r-- 1 root root 1935 Mar 10 2016
/usr/share/doc/perl-File-Rsync/README
-rw-r--r-- 1 root root 119 Jul 29 2015
/usr/share/doc/perl-File-Rsync/TODO
-rw-r--r-- 1 root root 6182 Feb 20 10:22
/usr/share/man/man3/File::Rsync.3pm.gz
drwxr-xr-x 2 root root 0 Feb 20 10:22
/usr/share/perl5/vendor_perl/File
-rw-r--r-- 1 root root 31052 Mar 9 2016
/usr/share/perl5/vendor_perl/File/Rsync.pm
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-File-Rsync-0.49-1.fc30.noarch.rpm |
sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(:VERSION) >= 5.8.0
1 perl(Carp)
1 perl(Data::Dumper)
1 perl(FileHandle)
1 perl(IPC::Run3)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rsync
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-File-Rsync-0.49-1.fc30.noarch.rpm |
sort -f | uniq -c
1 perl(File::Rsync) = 0.49
1 perl-File-Rsync = 0.49-1.fc30
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-File-Rsync-0.49-1.fc30.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F30
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=32921198). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the "FIX" item and consider fixing the "TODO" items
before
building this package.
Resolution: Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component