https://bugzilla.redhat.com/show_bug.cgi?id=1281722
Bug ID: 1281722 Summary: Review Request: perl-Unix-Mknod - Perl extension for mknod, major, minor, and makedev Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod-0.04-1.fc2... Description: This module allows access to the device routines major()/minor()/makedev() that may or may not be macros in .h files.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
--- Comment #1 from Petr Šabata psabata@redhat.com --- * Tip: You may drop the coreutils build time dependency if you substitute the `-exec rm -f {} ;' but with `-delete'.
* Tip: The Group tag isn't really needed nowadays.
* As this is an XS package, you should also BR gcc and perl-devel.
* I'm not sure the license could be really considered `MIT'; it looks like a combination of `MIT' and `BSD' (3-clause). I suggest you check with legal.
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Petr Šabata from comment #1)
- Tip: You may drop the coreutils build time dependency if you substitute
the `-exec rm -f {} ;' but with `-delete'.
Done
- Tip: The Group tag isn't really needed nowadays.
Group removed
- As this is an XS package, you should also BR gcc and perl-devel.
Added
- I'm not sure the license could be really considered `MIT'; it looks like a
combination of `MIT' and `BSD' (3-clause). I suggest you check with legal.
License is NCSA
https://lists.fedoraproject.org/pipermail/legal/2015-November/002717.html
Updated files: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod.spec https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod-0.04-2.fc2...
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata psabata@redhat.com --- (In reply to Jitka Plesnikova from comment #2)
(In reply to Petr Šabata from comment #1)
- Tip: The Group tag isn't really needed nowadays.
Group removed
Not really but it doesn't matter. The rest is fine now. Approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Unix-Mknod
https://bugzilla.redhat.com/show_bug.cgi?id=1281722
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Unix-Mknod-0.04-2.fc24 Resolution|--- |RAWHIDE Last Closed| |2015-11-19 03:24:18
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org