https://bugzilla.redhat.com/show_bug.cgi?id=2228918
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #14 from Vasiliy Glazov <vascom2(a)gmail.com> ---
Approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE.md is not marked as %license
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Packages have proper BuildRequires/Requires on javapackages-tools
(jpackage-utils)
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present. Note: Javadocs are optional for
Fedora versions >= 21
See:
https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See:
https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v2.0 or
later", "Apache License 1.1", "GNU Free Documentation License
v1.1",
"*No copyright* GNU General Public License", "GNU General Public
License, Version 2", "*No copyright* GNU General Public License GNU
Free Documentation License v1.1 or later", "*No copyright* Public
domain", "GNU Lesser General Public License v2.1 or later", "*No
copyright* GNU General Public License, Version 3", "*No copyright* GNU
Free Documentation License v1.1 or later", "*No copyright* GNU General
Public License v2.0 or later", "BSD 3-Clause License", "*No
copyright*
GNU General Public License, Version 2", "GNU Library General Public
License v2 or later [obsolete FSF postal address (Mass Ave)]", "GNU
Lesser General Public License Sun Public License v1.0", "GNU Library
General Public License v2 or later [obsolete FSF postal address
(Temple Place)]". 918 files have unknown license. Detailed output of
licensecheck in /home/vascom/2228918-jedit/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 4402 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
Maven:
[-]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: jedit-5.6.0-1.fc39.noarch.rpm
jedit-5.6.0-1.fc39.src.rpm
================================================================================
rpmlint session starts
================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4fmum612')]
checks: 31, packages: 2
jedit.noarch: E: uncompressed-zip /usr/share/java/jedit.jar
jedit.noarch: E: uncompressed-zip /usr/share/jedit/jedit.jar
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/doc/COPYING.DOC.txt
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/doc/COPYING.txt
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/keymaps/German_Keyboard_keys.props
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/C/Include_Guard.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Clipboard/Paste_Indent.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Duplicate_Lines_Above.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Duplicate_Lines_Below.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Mode_Switcher.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Browse_Buffer_Directory.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Browse_Directory.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Buffer_Switcher.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Duplicate_Buffer.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Path.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Selection.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Selection_In_Desktop.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Send_Buffer_To_Next_Split.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Toggle_ReadOnly.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Interface/Splitpane_Grow.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Java/Get_Package_Name.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Java/Java_File_Save.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Buffer_to_HyperSearch_Results.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Debug_BufferSets.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Debug_ScreenLines.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Abbreviations.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Actions.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Shortcuts.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Evaluate_Buffer_in_BeanShell.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Hex_Convert.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/HyperSearch_Results_to_Buffer.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Make_Bug_Report.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Run_Script.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Show_Threads.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/Create_Plugin_Announcement.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/Look_and_Feel_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/System_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/jEdit_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Add_Prefix_and_Suffix.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Color_Picker.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Duplicate_Line.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Insert_Date.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Insert_Tag.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Next_Char.bsh
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/modes/haxe.xml
jedit.noarch: E: incorrect-fsf-address
/usr/share/licenses/jedit/COPYING.DOC.txt
jedit.noarch: E: incorrect-fsf-address /usr/share/licenses/jedit/COPYING.txt
jedit.noarch: W: files-duplicate /usr/share/jedit/doc/README.txt
/usr/share/doc/jedit/README.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/Apache.LICENSE.txt
/usr/share/jedit/doc/Apache.LICENSE.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.DOC.txt
/usr/share/jedit/doc/COPYING.DOC.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.PLUGINS.txt
/usr/share/jedit/doc/COPYING.PLUGINS.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.txt
/usr/share/jedit/doc/COPYING.txt
================================================ 2 packages and 0 specfiles
checked; 47 errors, 5 warnings, 47 badness; has taken 0.6 s
================================================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
jedit.noarch: E: uncompressed-zip /usr/share/java/jedit.jar
jedit.noarch: E: uncompressed-zip /usr/share/jedit/jedit.jar
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/doc/COPYING.DOC.txt
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/doc/COPYING.txt
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/keymaps/German_Keyboard_keys.props
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/C/Include_Guard.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Clipboard/Paste_Indent.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Duplicate_Lines_Above.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Duplicate_Lines_Below.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Editing/Mode_Switcher.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Browse_Buffer_Directory.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Browse_Directory.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Buffer_Switcher.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Duplicate_Buffer.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Path.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Selection.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Open_Selection_In_Desktop.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Send_Buffer_To_Next_Split.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Files/Toggle_ReadOnly.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Interface/Splitpane_Grow.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Java/Get_Package_Name.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Java/Java_File_Save.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Buffer_to_HyperSearch_Results.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Debug_BufferSets.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Debug_ScreenLines.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Abbreviations.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Actions.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Display_Shortcuts.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Evaluate_Buffer_in_BeanShell.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Hex_Convert.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/HyperSearch_Results_to_Buffer.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Make_Bug_Report.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Run_Script.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Misc/Show_Threads.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/Create_Plugin_Announcement.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/Look_and_Feel_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/System_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Properties/jEdit_Properties.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Add_Prefix_and_Suffix.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Color_Picker.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Duplicate_Line.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Insert_Date.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Insert_Tag.bsh
jedit.noarch: E: incorrect-fsf-address
/usr/share/jedit/macros/Text/Next_Char.bsh
jedit.noarch: E: incorrect-fsf-address /usr/share/jedit/modes/haxe.xml
jedit.noarch: E: incorrect-fsf-address
/usr/share/licenses/jedit/COPYING.DOC.txt
jedit.noarch: E: incorrect-fsf-address /usr/share/licenses/jedit/COPYING.txt
jedit.noarch: W: files-duplicate /usr/share/jedit/doc/README.txt
/usr/share/doc/jedit/README.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/Apache.LICENSE.txt
/usr/share/jedit/doc/Apache.LICENSE.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.DOC.txt
/usr/share/jedit/doc/COPYING.DOC.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.PLUGINS.txt
/usr/share/jedit/doc/COPYING.PLUGINS.txt
jedit.noarch: W: files-duplicate /usr/share/licenses/jedit/COPYING.txt
/usr/share/jedit/doc/COPYING.txt
1 packages and 0 specfiles checked; 47 errors, 5 warnings, 47 badness; has
taken 0.3 s
Source checksums
----------------
https://sourceforge.net/projects/jedit/files/jedit/5.6.0/jedit5.6.0source...
:
CHECKSUM(SHA256) this package :
76c16ae0168d9b64ecddd8bf08aa49ab352adb2c9687191bc71895a96a8dfe1d
CHECKSUM(SHA256) upstream package :
76c16ae0168d9b64ecddd8bf08aa49ab352adb2c9687191bc71895a96a8dfe1d
Requires
--------
jedit (rpmlib, GLIBC filtered):
/usr/bin/sh
java
javapackages-filesystem
which
Provides
--------
jedit:
application()
application(jedit.desktop)
jedit
mimehandler(text/plain)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2228918
Buildroot used: fedora-rawhide-x86_64
Active plugins: Java, Generic, Shell-api
Disabled plugins: fonts, R, Python, PHP, Perl, Ocaml, Haskell, SugarActivity,
C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2228918
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...