https://bugzilla.redhat.com/show_bug.cgi?id=1984793
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing slash from the URL address.
Source0 archive (SHA512:
41e072ce4aec014c66c3fa6f1ce119ae595f96537d8afd3211f3e5dd99722ef332502877ad084d954ee829bbf87afc1e4b1eae46fc3dd984e09151d951fc0f66)
is original. Ok.
Summary verified from lib/Module/cpmfile.pm. Ok.
Description verified from lib/Module/cpmfile.pm. Ok.
License verified from lib/Module/cpmfile.pm, README, LICENSE, and META.json.
Ok.
No XS code, noarch BuildArch is Ok.
FIX: Build-require 'coreutils' (perl-Module-cpmfile.spec:48).
TODO: Remove an epoch from 'perl(:VERSION)' version constrain
(perl-Module-cpmfile.spec:11). It has no meaning.
TODO: If you removed t/author-pod-syntax.t in %prep section, you could save
from doing it in %install section and form unseting AUTHOR_TESTING in %check
section.
Build-dependencies are Ok.
All tests pass. Ok.
$ rpmlint perl-Module-cpmfile.spec
../SRPMS/perl-Module-cpmfile-0.001-1.fc35.src.rpm
../RPMS/noarch/perl-Module-cpmfile-*
========================================================== rpmlint session
starts =========================================================
rpmlint: 2.0.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4
perl-Module-cpmfile-tests.noarch: W: no-documentation
perl-Module-cpmfile.noarch: W: files-duplicate
/usr/share/man/man3/Module::cpmfile::Util.3pm.gz
/usr/share/man/man3/Module::cpmfile::Prereqs.3pm.gz
=========================== 3 packages and 1 specfiles checked; 0 errors, 2
warnings, 0 badness; has taken 0.4 s ==========================
rpmlint is Ok.
TODO: Maybe removing empty Module::cpmfile::Util(3pm) and
Module::cpmfile::Prereqs(3pm) file would be great.
$ rpm -q -lv -p ../RPMS/noarch/perl-Module-cpmfile-0.001-1.fc35.noarch.rpm
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/share/doc/perl-Module-cpmfile
-rw-r--r-- 1 root root 90 Jul 21 04:51
/usr/share/doc/perl-Module-cpmfile/Changes
-rw-r--r-- 1 root root 752 Jul 21 04:51
/usr/share/doc/perl-Module-cpmfile/README
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/share/licenses/perl-Module-cpmfile
-rw-r--r-- 1 root root 18400 Jul 21 04:51
/usr/share/licenses/perl-Module-cpmfile/LICENSE
-rw-r--r-- 1 root root 2213 Aug 2 13:06
/usr/share/man/man3/Module::cpmfile.3pm.gz
-rw-r--r-- 1 root root 20 Aug 2 13:06
/usr/share/man/man3/Module::cpmfile::Prereqs.3pm.gz
-rw-r--r-- 1 root root 20 Aug 2 13:06
/usr/share/man/man3/Module::cpmfile::Util.3pm.gz
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/share/perl5/vendor_perl/Module
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/share/perl5/vendor_perl/Module/cpmfile
-rw-r--r-- 1 root root 3812 Jul 21 04:51
/usr/share/perl5/vendor_perl/Module/cpmfile.pm
-rw-r--r-- 1 root root 2434 Jul 21 04:51
/usr/share/perl5/vendor_perl/Module/cpmfile/Prereqs.pm
-rw-r--r-- 1 root root 464 Jul 21 04:51
/usr/share/perl5/vendor_perl/Module/cpmfile/Util.pm
$ rpm -q -lv -p
../RPMS/noarch/perl-Module-cpmfile-tests-0.001-1.fc35.noarch.rpm
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/libexec/perl-Module-cpmfile
drwxr-xr-x 2 root root 0 Aug 2 13:06
/usr/libexec/perl-Module-cpmfile/t
-rwxr-xr-x 1 root root 941 Aug 2 13:06
/usr/libexec/perl-Module-cpmfile/t/01_basic.t
-rwxr-xr-x 1 root root 553 Aug 2 13:06
/usr/libexec/perl-Module-cpmfile/t/02_cpanfile.t
drwxr-xr-x 2 root root 0 Jul 21 04:51
/usr/libexec/perl-Module-cpmfile/t/data
-rw-r--r-- 1 root root 185 Jul 21 04:51
/usr/libexec/perl-Module-cpmfile/t/data/cpanfile
-rw-r--r-- 1 root root 406 Jul 21 04:51
/usr/libexec/perl-Module-cpmfile/t/data/cpm.yml
drwxr-xr-x 2 root root 0 Jul 21 04:51
/usr/libexec/perl-Module-cpmfile/t/lib
-rw-r--r-- 1 root root 280 Jul 21 04:51
/usr/libexec/perl-Module-cpmfile/t/lib/Util.pm
-rwxr-xr-x 1 root root 103 Aug 2 13:06
/usr/libexec/perl-Module-cpmfile/test
File layout and permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Module-cpmfile-0.001-1.fc35.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.34.0)
1 perl(:VERSION) >= 5.8.1
1 perl(CPAN::Meta::Prereqs)
1 perl(CPAN::Meta::Requirements)
1 perl(Exporter)
1 perl(Module::cpmfile::Prereqs)
1 perl(Module::cpmfile::Util)
1 perl(strict)
1 perl(warnings)
1 perl(YAML::PP)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Add version contrains to 'perl(CPAN::Meta::Requirements)',
'perl(Exporter)', and 'perl(YAML::PP)' run-time dependencies to match the
build
dependencies.
$ rpm -q --requires -p
../RPMS/noarch/perl-Module-cpmfile-tests-0.001-1.fc35.noarch.rpm | sort -f |
uniq -c
1 /usr/bin/perl
1 /usr/bin/sh
1 perl(Data::Dumper)
1 perl(Exporter)
1 perl(lib)
1 perl(Module::CPANfile)
1 perl(Module::cpmfile)
1 perl(strict)
1 perl(Test2::V0)
1 perl(Util)
1 perl(warnings)
1 perl-Module-cpmfile = 0.001-1.fc35
1 perl-Test-Harness
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Remove a dependency on private 'perl(Util)'.
$ rpm -q --provides -p
../RPMS/noarch/perl-Module-cpmfile-0.001-1.fc35.noarch.rpm | sort -f | uniq -c
1 perl(Module::cpmfile) = 0.001
1 perl(Module::cpmfile::Prereqs)
1 perl(Module::cpmfile::Util)
1 perl-Module-cpmfile = 0.001-1.fc35
$ rpm -q --provides -p
../RPMS/noarch/perl-Module-cpmfile-tests-0.001-1.fc35.noarch.rpm | sort -f |
uniq -c
1 perl(Util)
1 perl-Module-cpmfile-tests = 0.001-1.fc35
FIX: Remove a dependency on private 'perl(Util)'.
$ resolvedeps rawhide ../RPMS/noarch/perl-Module-cpmfile-*
Binary dependencies are resolvable. Ok.
The package builds in F35
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=73137783). Ok.
The packaged tests pass. Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all the FIX items and consider fixing the TODO items.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component