https://bugzilla.redhat.com/show_bug.cgi?id=1301286
--- Comment #8 from Neal Gompa <ngompa13(a)gmail.com> ---
Spec review notes:
Please use the scheme detailed in the guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
%setup -qn %{name}-%{version}
The "-n %{name}-%{version}" is redundant and pointless because this is already
default. You can use "%setup -q" or "%autosetup" instead. Consider
setting
"%autosetup -p1" so that in the event you have patches, they'll be
automatically applied correctly.
sed -i -e 's#/usr/lib#%{_libdir}#g' etc/disable-devel.inc
This looks fine to me, but consider changing from hash marks to a different
symbol, as it gets trick with shell evaluation. I usually use the '|' character
as it is meaningless in a string and really bad syntax highlighters will
highlight them, making it easier to see the separations.
make %{?_smp_mflags}
Consider using "%make_build". It works on all currently supported Fedora and
EPEL targets.
make install DESTDIR=%{buildroot}
Consider using "%make_install".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component