Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Summary: Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mgoldman@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://goldmann.fedorapeople.org/package_review/jansi/1/jansi.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jansi/1/jansi-1.5-1.fc16.src... Description:
Jansi is a small java library that allows you to use ANSI escape sequences in your Java console applications. It implements ANSI support on platforms which don't support it like Windows and provides graceful degradation for when output is being sent to output devices which cannot support ANSI sequences.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183(FE-JAVASIG) Depends on| |708669, 708836
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |709051
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |709300
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Bug 708842 depends on bug 708669, which changed state.
Bug 708669 Summary: xbean doesn't contain xbean-finder and xbean-bundleutils submodules https://bugzilla.redhat.com/show_bug.cgi?id=708669
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED
Bug 708842 depends on bug 708836, which changed state.
Bug 708836 Summary: Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project. https://bugzilla.redhat.com/show_bug.cgi?id=708836
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |akurtako@redhat.com AssignedTo|nobody@fedoraproject.org |akurtako@redhat.com Flag| |fedora-review?
--- Comment #1 from Alexander Kurtakov akurtako@redhat.com 2011-07-29 07:55:43 EDT --- I would do this one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
--- Comment #2 from Alexander Kurtakov akurtako@redhat.com 2011-07-29 08:05:39 EDT --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [!] Rpmlint output: jansi.noarch: W: summary-ended-with-dot C Jansi is a java library for generating and interpreting ANSI escape sequences. Please fix jansi.noarch: W: name-repeated-in-summary C Jansi Just skipping "Jansi is a" from the beginning jansi-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: ASL 2.0 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!] All independent sub-packages have license of their own Javadoc is missing it [x] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [!] pom files has correct add_maven_depmap
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [!] Package DOES NOT use %update_maven_depmap in %post/%postun [!] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro
=== Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [!] Latest version is packaged. 1.6 is out
=== Issues === 1. Rpmlint warnings 2. Missing license in the javadoc subpackage 3. Use the new add_maven_depmap macro 4. Remove update_maven_depmap and Requires(post|postun) on jpackage=utils 5. Update to version 1.6.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
--- Comment #3 from Marek Goldmann mgoldman@redhat.com 2011-08-25 08:38:20 EDT --- Spec URL: http://goldmann.fedorapeople.org/package_review/jansi/2/jansi.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jansi/2/jansi-1.6-1.fc17.src...
- Upstream release 1.6 - Spec file cleanup
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Alexander Kurtakov akurtako@redhat.com 2011-08-26 08:05:59 EDT --- Summary-ended-with-dot warning is still there but I would not block on it. Please fix with the initial import.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Marek Goldmann mgoldman@redhat.com 2011-08-29 05:00:23 EDT --- Thanks for review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
--- Comment #6 from Marek Goldmann mgoldman@redhat.com 2011-08-29 05:01:41 EDT --- New Package SCM Request ======================= Package Name: jansi Short Description: Jansi is a java library for generating and interpreting ANSI escape sequences Owners: goldmann
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-08-29 07:59:17 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-08-29 09:04:47
--- Comment #8 from Marek Goldmann mgoldman@redhat.com 2011-08-29 09:04:47 EDT --- Thanks for git, closing!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183(FE-JAVASIG) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
hannes johannes.lips@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johannes.lips@googlemail.co | |m
--- Comment #9 from hannes johannes.lips@googlemail.com 2011-10-13 10:17:30 EDT --- Package Change Request ====================== Package Name: jansi New Branches: f16 Owners: goldmann hannes InitialCC:
I would like to add jansi to f16 to make it available as a dep of groovy and don't need to patch it out. So it will make the life easier for the groovy maintainers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
hannes johannes.lips@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708842
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2011-10-13 10:18:56 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org