Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497805
Christian Krause <chkr(a)plauener.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Christian Krause <chkr(a)plauener.de> 2009-04-29 17:48:11 EDT
---
* rpmlint: OK
rpmlint SPECS/cppcheck.spec RPMS/i386/cppcheck-*
SRPMS/cppcheck-1.31-1.fc10.src.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
* naming: OK
- name matches upstream
- spec file name %{name}.spec
* License: OK
- GPLv3+ acceptable for Fedora
- license matches the actual license in the source files
- license file packaged
* spec file in English and legible: OK
* sources matches upstream: OK
- spectool -g cppcheck.spec works
- md5sum: db500cee39ceaa7379bb105046d36cce cppcheck-1.31.tar.bz2
* package compiles: OK
- rpm's %{optflags} are used correctly
- mock build successful
- koji builds for F10, F11 and F12 successful for all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329473
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329468
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329463
* build requirements: OK
- the BR: gcc-c++ is not necessarily needed, since gcc-c++ is already in
the minimum build environment:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- however, it is not forbidden to add it anyway
* locales handling: OK (n/a)
* handling of static/shared objects, pkgconfig, header files, etc: OK (n/a)
* owns all directories it creates: OK
* no files listed twice in %files: OK
* permissions on files: OK
- %defattr used
- actual permissions in binary rpm OK
* clean section: OK
- rm -rf %{buildroot} used
* macro usage: OK
* code vs. content: OK
- only code and test c++ files
* large documentation in subpackage: OK (n/a)
- the test files are only 300K
* no *.la files: OK
* GUI application needs *.desktop file: OK (n/a)
* package must not own files/dirs owned by other packages: OK
* rm -rf %{buildroot} at beginning of %install: OK
* filenames UTF-8: OK
* functional test: OK
- used some of the code snippets from the test files to verify the
functionality of cppcheck
* debuginfo: OK
- debuginfo package not empty
- debuginfo actually usable
No problems found => APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.