https://bugzilla.redhat.com/show_bug.cgi?id=1338999
Bug ID: 1338999 Summary: Review Request: perl-MooseX-Role-Strict - Use strict 'roles' in Moose Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX... Description: When using Moose::Role, a class which provides a method a role provides will silently override that method. This can cause strange, hard-to-debug errors when the role's methods are not called. Simply use MooseX::Role::Strict instead of Moose::Role and overriding a role's method becomes a composition-time failure.
Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1337889
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1337889 [Bug 1337889] perl-MooseX-ClassAttribute-0.28 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-MooseX-Role-Strict-0.05-1.fc25.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Moose) 1 perl(Moose::Exporter) 1 perl(Moose::Meta::Role) 1 perl(Moose::Meta::Role::Application::ToClass) 1 perl(Moose::Role) 1 perl(MooseX::Meta::Role::Strict) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-MooseX-Role-Strict-0.05-1.fc25.noarch.rpm | sort | uniq -c 1 perl(MooseX::Meta::Role::Strict) = 0.05 1 perl(MooseX::Role::Strict) = 0.05 1 perl-MooseX-Role-Strict = 0.05-1.fc25 Binary provides are Ok.
$ rpmlint ./perl-MooseX-Role-Strict* perl-MooseX-Role-Strict.noarch: E: wrong-script-interpreter /usr/share/doc/perl-MooseX-Role-Strict/xt/pod.t perl 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
TODO: Please remove 'xt' from %doc.
Please consider fixing 'TODO' items.
Otherwise package looks good. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
--- Comment #2 from Emmanuel Seyman emmanuel@seyman.fr --- Thank you, Jikta. I've amended the spec file.
Spec URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX...
I've also requested the repo in pkgdb.
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooseX-Role-Strict
https://bugzilla.redhat.com/show_bug.cgi?id=1338999
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-05-26 11:17:04
--- Comment #4 from Emmanuel Seyman emmanuel@seyman.fr --- The package has been imported, built for rawhide and updates have been issued for F24 and F23.
Thank you for the review, Jikta.
package-review@lists.fedoraproject.org