Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #6 from Jeroen van Meeuwen <kanarip(a)kanarip.com> 2009-01-14 07:53:01
EDT ---
(In reply to comment #5)
Could you define "WinPE" in your %description? Just a
parenthetical "Windows
Preinstallation Environment" should be sufficient. Also, it needs a period at
the end.
Fixed.
You're missing Requires(preun): initscripts, and also a python
dependency for
your %post script.
Fixed.
Does it make sense to include the sample .sif files? What about the
manual
from the upstream web site (
http://oss.netfarm.it/guides/ris-linux.pdf)?
I've included the sample .sif file, although I'm reluctant to say it's good
enough.
The upstream .pdf documentation though I'm not including. Other documentation
is in the works that includes using Cobbler to manage the largest part of what
is in the upstream documentation, and I'd rather set the record straight then
whilst not confusing users of the package now (like with patching in.tftpd).
This package is a little odd in that it installs as a service, but
doesn't
actually put any executables in %path. There isn't anything in the guidelines
that would prohibit this as far as I can tell, but it seems a little
admin-unfriendly. I don't know what to do about it; maybe a wrapper script
that just calls "python /usr/share/ris-linux/binlsrv.py". But I'll leave
that
up to you.
Fixed, and actually works way better for "service ris-linuxd status". Maybe
this should be a Packaging Guidelines? ;-)
New SPEC:
http://www.kanarip.com/custom/SPECS/ris-linux.spec
New SRPM:
http://www.kanarip.com/custom/f10/SRPMS/ris-linux-0.4-4.fc10.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.