https://bugzilla.redhat.com/show_bug.cgi?id=1290450
--- Comment #2 from Antonio Trande <anto.trande(a)gmail.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
--enable-gcov → Why build with coverage? This seems only useful for
development.
Likewise --enable-asserts: all binaries emit the following warning:
** (process:8647): WARNING **: Compiled with assertion checking - will run
slowly
Maybe the slowdown is not too big, in which case it might be worth to leave
this
on, at least initially.
Honestly, I ignored what they served.
make install DESTDIR=... → %make_install (for brevity)
- license is OK
- license file is present, %license is used
- latest version
- proper build flags are used
- builds and installs OK
- fedora-review doesn't find any issues
- no scriptlets
- requires/provides are OK
- check is present and passes
rpmlint:
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/fastautils.1.gz
59: warning: macro `..' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/fastautils.1.gz
78: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz
36: warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz
49: warning: macro `SP' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/exonerate.1.gz
1342: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 22: warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 373: warning: macro `SP' not
defined
exonerate.x86_64: W: manual-page-warning
/usr/share/man/man1/exonerate-server.1.gz 449: warning: macro `L' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz
38: warning: macro `T' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz
71: warning: macro `SP' not defined
exonerate.x86_64: W: manual-page-warning /usr/share/man/man1/ipcress.1.gz
261: warning: macro `L' not defined
They mostly display OK, I'm not sure what those warnings mean exactly.
manpages should be renovated, i think.
Too bad ;)
Looks good, except for a few trivial issues. Package is APPROVED.
Thank you.
Spec URL:
https://sagitter.fedorapeople.org/exonerate/exonerate.spec
SRPM URL:
https://sagitter.fedorapeople.org/exonerate/exonerate-2.2.0-2.fc23.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component