https://bugzilla.redhat.com/show_bug.cgi?id=989266
gil cattaneo <puntogil(a)libero.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #4 from gil cattaneo <puntogil(a)libero.it> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs properly.
Note: Installation errors (see attachment)
See:
https://fedoraproject.org/wiki/Packaging:Guidelines
- Fully versioned dependency in subpackages, if present.
Note: Missing: Requires: %{name} = %{version}-%{release} in milyn, milyn-
commons, milyn-smooks-core, milyn-scribe, milyn-scribe-core, milyn-scribe-
adapter, milyn-scribe-jpa, milyn-scribe-hibernate, smooks-cartridge-base-
pom, milyn-edisax-parser
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[ ]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in smooks-
javadoc , milyn , milyn-commons , milyn-smooks-core , milyn-scribe ,
milyn-scribe-core , milyn-scribe-adapter , milyn-scribe-jpa , milyn-
scribe-hibernate , smooks-cartridge-base-pom , milyn-edisax-parser
[x]: Package complies to the Packaging Guidelines
[ ]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "LGPL (v2.1))", "Unknown or
generated". 156 files have
unknown license.
ASL 2.0:
smooks-cartridges/camel/src/test/java/org/milyn/smooks/camel/component/SmooksComponentTest.java
smooks-cartridges/camel/src/test/java/org/milyn/smooks/camel/dataformat/Customer.java
smooks-cartridges/camel/src/test/java/org/milyn/smooks/camel/dataformat/Gender.java
smooks-cartridges/camel/src/test/java/org/milyn/smooks/camel/dataformat/SmooksCSVDataFormatTest.java
smooks-cartridges/camel/src/test/java/org/milyn/smooks/camel/processor/SmooksProcessorTest.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/Broker.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/BrokerServices.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/Main.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/Event.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/EventFeeder.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/EventGenerator.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/EventImpl.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/EventReceiver.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/EventSource.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/events/StockTickPersister.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/misc/Utils.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/Action.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/Company.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/CompanyRegistry.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/PortfolioAction.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/StockTick.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/model/SuddenDropEvent.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/ui/BrokerWindow.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/ui/CompanyPanel.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/ui/LogPanel.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/ui/ScrollingBanner.java
smooks-examples/drools-fusion/src/main/java/org/drools/examples/broker/ui/Utils.java
smooks-examples/drools-fusion/src/test/java/org/drools/examples/broker/events/EventFeederTest.java
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: If tests are skipped during package build explain why it was needed in a
comment
Note: Tests seem to be skipped. Verify there is a commment giving a
reason for this
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Installation errors
-------------------
INFO: mock.py version 1.1.32 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.32
INFO: Mock Version: 1.1.32
Start: lock buildroot
INFO: installing package(s):
/home/gil/989266-smooks/results/smooks-javadoc-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-commons-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-smooks-core-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-scribe-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-scribe-core-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-scribe-adapter-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-scribe-jpa-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-scribe-hibernate-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/smooks-cartridge-base-pom-1.5.1-2.fc20.noarch.rpm
/home/gil/989266-smooks/results/milyn-edisax-parser-1.5.1-2.fc20.noarch.rpm
ERROR: Command failed:
# ['/usr/bin/yum', '--installroot',
'/var/lib/mock/fedora-rawhide-i386/root/',
'install',
'/home/gil/989266-smooks/results/smooks-javadoc-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-commons-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-smooks-core-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-scribe-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-scribe-core-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-scribe-adapter-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-scribe-jpa-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-scribe-hibernate-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/smooks-cartridge-base-pom-1.5.1-2.fc20.noarch.rpm',
'/home/gil/989266-smooks/results/milyn-edisax-parser-1.5.1-2.fc20.noarch.rpm',
'--setopt=tsflags=nocontexts']
Errore: Pacchetto: milyn-commons-1.5.1-2.fc20.noarch
(/milyn-commons-1.5.1-2.fc20.noarch)
Richiede: mvn(hsqldb:hsqldb)
Si può provare ad usare --skip-broken per aggirare il problema
Provare ad eseguire: rpm -Va --nofiles --nodigest
Rpmlint
-------
Checking: smooks-javadoc-1.5.1-2.fc20.noarch.rpm
milyn-1.5.1-2.fc20.noarch.rpm
milyn-commons-1.5.1-2.fc20.noarch.rpm
milyn-smooks-core-1.5.1-2.fc20.noarch.rpm
milyn-scribe-1.5.1-2.fc20.noarch.rpm
milyn-scribe-core-1.5.1-2.fc20.noarch.rpm
milyn-scribe-adapter-1.5.1-2.fc20.noarch.rpm
milyn-scribe-jpa-1.5.1-2.fc20.noarch.rpm
milyn-scribe-hibernate-1.5.1-2.fc20.noarch.rpm
smooks-cartridge-base-pom-1.5.1-2.fc20.noarch.rpm
milyn-edisax-parser-1.5.1-2.fc20.noarch.rpm
milyn.noarch: W: name-repeated-in-summary C Milyn
milyn.noarch: W: no-documentation
milyn-commons.noarch: W: no-documentation
milyn-smooks-core.noarch: W: spelling-error %description -l en_US serialisation
-> serialization, sensationalist, sensationalism
milyn-smooks-core.noarch: W: no-documentation
milyn-scribe.noarch: W: no-documentation
milyn-scribe-core.noarch: W: no-documentation
milyn-scribe-adapter.noarch: W: no-documentation
milyn-scribe-jpa.noarch: W: no-documentation
milyn-scribe-hibernate.noarch: W: no-documentation
smooks-cartridge-base-pom.noarch: W: no-documentation
milyn-edisax-parser.noarch: W: no-documentation
11 packages and 0 specfiles checked; 0 errors, 12 warnings.
Diff spec file in url and in SRPM
---------------------------------
--- /home/gil/989266-smooks/srpm/smooks.spec 2013-07-31 11:09:54.470554051
+0200
+++ /home/gil/989266-smooks/srpm-unpacked/smooks.spec 2013-07-31
11:09:55.271512522 +0200
@@ -253,5 +253,4 @@
* Tue Jul 30 2013 Gerard Ryan <galileo(a)fedoraproject.org> - 1.5.1-2
- RHBZ-989266: Fix hsqldb version; add BR's
-- Remove milyn-smooks-camel subpackage
* Sat Jul 27 2013 Gerard Ryan <galileo(a)fedoraproject.org> - 1.5.1-1
Requires
--------
milyn-scribe-hibernate (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.hibernate:hibernate-core)
mvn(org.milyn:milyn-scribe-core)
milyn-commons (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(hsqldb:hsqldb)
mvn(javassist:javassist)
mvn(org.freemarker:freemarker)
milyn (rpmlib, GLIBC filtered):
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.apache.maven.plugins:maven-assembly-plugin)
mvn(org.apache.maven.plugins:maven-compiler-plugin)
mvn(org.apache.maven.plugins:maven-source-plugin)
mvn(org.apache.maven.plugins:maven-surefire-plugin)
mvn(org.codehaus:codehaus-parent)
smooks-javadoc (rpmlib, GLIBC filtered):
jpackage-utils
milyn-scribe-adapter (rpmlib, GLIBC filtered):
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.milyn:milyn-scribe)
mvn(org.milyn:milyn-scribe-core)
smooks-cartridge-base-pom (rpmlib, GLIBC filtered):
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.milyn:milyn)
mvn(org.milyn:milyn-smooks-core)
milyn-edisax-parser (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.milyn:milyn-commons)
milyn-scribe (rpmlib, GLIBC filtered):
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.milyn:milyn)
milyn-scribe-core (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(org.milyn:milyn-commons)
milyn-scribe-jpa (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(javax.persistence:persistence-api)
mvn(org.milyn:milyn-scribe-core)
milyn-smooks-core (rpmlib, GLIBC filtered):
java
jpackage-utils
mvn(com.thoughtworks.xstream:xstream)
mvn(com.wutka:dtdparser)
mvn(commons-lang:commons-lang)
mvn(commons-logging:commons-logging)
mvn(javax.transaction:jta)
mvn(jaxen:jaxen)
mvn(org.milyn:milyn-commons)
mvn(org.mvel:mvel2)
Provides
--------
milyn-scribe-hibernate:
milyn-scribe-hibernate
mvn(org.milyn:milyn-scribe-hibernate)
milyn-commons:
milyn-commons
mvn(org.milyn:milyn-commons)
milyn:
milyn
mvn(org.milyn:milyn)
smooks-javadoc:
smooks-javadoc
milyn-scribe-adapter:
milyn-scribe-adapter
mvn(org.milyn:milyn-scribe-adapter)
smooks-cartridge-base-pom:
mvn(org.milyn:smooks-cartridge-base-pom)
smooks-cartridge-base-pom
milyn-edisax-parser:
milyn-edisax-parser
mvn(org.milyn:milyn-edisax-parser)
milyn-scribe:
milyn-scribe
mvn(org.milyn:milyn-scribe)
milyn-scribe-core:
milyn-scribe-core
mvn(org.milyn:milyn-scribe-core)
milyn-scribe-jpa:
milyn-scribe-jpa
mvn(org.milyn:milyn-scribe-jpa)
milyn-smooks-core:
milyn-smooks-core
mvn(org.milyn:milyn-smooks-core)
Source checksums
----------------
https://github.com/smooks/smooks/archive/4653c12fbfd94b1423111d9f296a764a...
:
CHECKSUM(SHA256) this package :
7d124af9dbebb6450be52ba97051a5541b6cc521777cd4bb264390a82d874a1d
CHECKSUM(SHA256) upstream package :
7d124af9dbebb6450be52ba97051a5541b6cc521777cd4bb264390a82d874a1d
Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-i386
Command line :/usr/bin/fedora-review -b 989266 -m fedora-rawhide-i386
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OHB6W5HNBf&a=cc_unsubscribe