Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=637491
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> 2010-11-04 08:59:34 EDT ---
Spec file changes:
--- perl-Params-Classify.spec 2010-09-26 09:22:44.000000000 +0200
+++ perl-Params-Classify.spec.1 2010-11-04 11:33:13.000000000 +0100
@@ -1,15 +1,20 @@
Name: perl-Params-Classify
-Version: 0.011
+Version: 0.012
Release: 1%{?dist}
Summary: Argument type classification
License: GPL+ or Artistic
Group: Development/Libraries
URL:
http://search.cpan.org/dist/Params-Classify/
Source0:
http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Params-Classify-%{version}.tar.gz
+BuildRequires: perl(ExtUtils::ParseXS)
BuildRequires: perl(Module::Build)
BuildRequires: perl(parent)
+BuildRequires: perl(Scalar::Util) >= 1.01
BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
Requires: perl(Exporter)
+Requires: perl(Scalar::Util) >= 1.01
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%{?perl_default_filter}
@@ -25,7 +30,7 @@
%setup -q -n Params-Classify-%{version}
%build
-%{__perl} Build.PL installdirs=vendor optimize="%{optimize}"
+%{__perl} Build.PL installdirs=vendor optimize="%{optflags}"
./Build
%install
@@ -46,5 +51,9 @@
%{_mandir}/man3/*
%changelog
+* Thu Nov 04 2010 Iain Arnell <iarnell(a)gmail.com> 0.012-1
+- update to latest upstream version
+- use correct optflags macro
+
* Sun Sep 26 2010 Iain Arnell <iarnell(a)gmail.com> 0.011-1
- Specfile autogenerated by cpanspec 1.78.
FIXME: BuildRequire perl(Scalar::Util) >= 1.1 as it can be
dual-live package
in the future (
http://search.cpan.org/~gbarr/Scalar-List-Utils/)
Ok.
> > %{__perl} Build.PL installdirs=vendor
optimize="%{optimize}"
> What's the `optimize' macro and argument?
Oops. optimze=%{optimize} is a bug in cpanspec. Fixed to use %{optflags}.
-%{__perl} Build.PL installdirs=vendor optimize="%{optimize}"
+%{__perl} Build.PL installdirs=vendor optimize="%{optflags}"
/usr/lib/rpm/rpmrc. Ok.
> t/pod_cvg.t ...... skipped: Test::Pod::Coverage not available
> t/pod_cvg_pp.t ... skipped: Test::Pod::Coverage not available
> t/pod_syn.t ...... skipped: Test::Pod not available
FIX: BuildRequire perl(Test::Pod) and perl(Test::Pod::Coverage).
Ok.
Source file original. Ok.
License verified from README. Ok.
+ /usr/bin/perl Build.PL installdirs=vendor 'optimize=-O2 -g
-pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic'
Creating custom builder _build/lib/MyModuleBuilder.pm in _build/lib
Checking whether your kit is complete...
Looks good
Checking prerequisites...
- ERROR: ExtUtils::ParseXS (2.2002) is installed, but we need version
>= 2.2006
FIX: Version perl(ExtUtils::ParseXS) >= 2.006 BuildRequires.
All tests pass. Ok.
Package builds in F15
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=2576190). Ok.
$ rpmlint perl-Params-Classify.spec
../SRPMS/perl-Params-Classify-0.012-1.fc15.src.rpm
../RPMS/x86_64/perl-Params-Classify-0.012-1.fc15.x86_64.rpm
perl-Params-Classify.spec: W: no-cleaning-of-buildroot %clean
perl-Params-Classify.spec: W: no-buildroot-tag
perl-Params-Classify.spec: W: no-%clean-section
perl-Params-Classify.src: W: no-cleaning-of-buildroot %clean
perl-Params-Classify.src: W: no-buildroot-tag
perl-Params-Classify.src: W: no-%clean-section
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint Ok.
$ rpm -pq --requires
../RPMS/x86_64/perl-Params-Classify-0.012-1.fc15.x86_64.rpm | sort | uniq -c
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libc.so.6()(64bit)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.12.2)
1 perl(parent)
1 perl(Scalar::Util) >= 1.01
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
2 rpmlib(VersionedDependencies) <= 3.0.3-1
1 rtld(GNU_HASH)
$ rpm -pq --provides
../RPMS/x86_64/perl-Params-Classify-0.012-1.fc15.x86_64.rpm | sort | uniq -c
1 perl-Params-Classify(x86-64) = 0.012-1.fc15
1 perl(Params::Classify) = 0.012
1 perl-Params-Classify = 0.012-1.fc15
Binary dependencies Ok.
Please add the version to perl(ExtUtils::ParseXS) before commit.
Resolution: Package APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.