https://bugzilla.redhat.com/show_bug.cgi?id=2131602
Otto Liljalaakso <otto.liljalaakso(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(thofmann@fedorapr
| |oject.org)
--- Comment #2 from Otto Liljalaakso <otto.liljalaakso(a)iki.fi> ---
Name: nagios-plugins-check_ssl_cert
As discussed in bug 2082886,
following the usual Nagios plugin naming,
this should be nagion-plugins-ssl_cert.
(This comment is not review blocking.)
Version: 2.49.0
This is not the latest version.
v2.25.0 is out already.
The latest version should be packaged.
However, upstream releases so often (three releases yesterday!),
that I am not going to block the review because of this.
This link is not correct.
It shows a corrupted version of the /directory/ path.
Appending /details/ shows the intended page.
However, that page has not been updated since 2020-08,
and e.g. claims that the latest version is 1.122.0.
I am not sure if it better to use this or the GitHub repo — your call.
[!]: %check is present and all tests pass.
Upstream provides folder test/ with some tests,
either execute it or provide a comment explaining why not.
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
This is just because 'fedpkg srpm', fedora-review and rpmautospec are not
compatible.
No action needed, just do not try to 'fedpkg import' that srpm.
nagios-plugins-check_ssl_cert.x86_64: W: only-non-binary-in-usr-lib
$ rpmlint -e only-non-binary-in-usr-lib
only-non-binary-in-usr-lib:
There are only non binary files in /usr/lib so they should be in /usr/share.
Nagios plugins directory in under /usr/lib64, putting a shell script there is
valid.
No action needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2131602