https://bugzilla.redhat.com/show_bug.cgi?id=1310434
--- Comment #8 from Scott Talbert <swt(a)techie.net> ---
Thanks a lot for the review! I'll get working on your comments.
(In reply to Miro Hrončok from comment #2)
Python 2 install uses easy_install, Python 3 uses build.py, is there
a
reason for the difference?
Yes, it's so the Python 2 version will get installed in a location that doesn't
conflict with the wxPython 3.0 package. I believe I roughly followed this
guidance here for having multiple versions of the same module:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Multiple_Versions
What's up with tests? They seem to be both disabled and || true.
Do they
fail totally, or only some fail?
Hah. It's been so long since I tried to run them in mock or koji that I can't
exactly remember. There are definitely some tests that fail, but I'm not sure
if I ever got the tests to run at all successfully under mock/koji (due to
needing a display since most of the tests are GUI-based). I'll try them again
and see what happens now.
Maybe use bcond for disabling tests, so it's easy to enable them
locally
with command line witch.
The docs package doesn't seem to provide/obsolete the copr
python-wx-phoenix-docs.
Maybe you can get rid fo groups declarations?
Maybe you can just set Summary and use %{summary} everywhere instead of
%{sum}? (Not important, just a suggestion.)
Building now for more stuff...
All good catches, thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component