Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579919
--- Comment #2 from Fabian Deutsch <fabian.deutsch(a)gmx.de> 2010-05-04 06:42:50 EDT
---
rpmlint says something:
$ rpmlint -v isight-firmware-tools.spec
isight-firmware-tools.spec:40: W: macro-in-comment %doc
isight-firmware-tools.spec: I: checking-url
http://bersace03.free.fr/ift/isight-firmware-tools-1.5.90.tar.gz (timeout 10
seconds)
isight-firmware-tools.spec: W: invalid-url Source0:
http://bersace03.free.fr/ift/isight-firmware-tools-1.5.90.tar.gz HTTP Error
404: Not Found
0 packages and 1 specfiles checked; 0 errors, 2 warnings.
- macro-in-comment: you can fix this by removing the % in line 40.
- invalid-url: The source URL does not exist, you will have to give a correct
url.
(
http://launchpad.net/isight-firmware-tools/main/1.6/+download/%{name}-%{v...
maybe?)
- To sanitize the specfile, it woul dbe nice to replace $RPM_BUILD_ROOT with
%{buildroot}, so you use the %{...} all the time.
- You need to add a builddep on intltool
- Currently th isight udev rule is included with the following line:
%config(noreplace) %{_sysconfdir}/udev/rules.d/isight.rules
so existing udev rules will not be overwritten. I wonder why that is ...
In my case (F13/Rawhide) the isight rule does not match the current udev
syntax, so a warning is generated ...:
SYSFS{}= will be removed in a future udev version, please use ATTR{}= to match
the event device, or ATTRS{}= to match a parent device, in
/etc/udev/rules.d/isight.rules:1
This should also be addressed.
After at least adding the builddep, the package builds fine in koji.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.