Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
Summary: Review Request: pachi - Pachi El Marciano - Platform Game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/pachi.spec SRPM URL: http://people.atrpms.net/~hdegoede/pachi-1.0-1.src.rpm Description: Pachi El Marciano is a cool 2D platform game inspired by the likes of Manic Miner, Jet Set Willy, and more from the '80s.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
michel.salim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |michel.salim@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
------- Additional Comments From michel.salim@gmail.com 2006-11-10 16:57 EST ------- Will do a full review later this evening, but quick question: why is the Pachi binary SUID root? I've not had time to test it much, but the game starts and acts normally when I removed its SUID bit.
(one rpmlint error on the binary from this)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-10 17:45 EST ------- It isn't suid root, its sgid games, unless something has gone wrong.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
------- Additional Comments From michel.salim@gmail.com 2006-11-10 20:24 EST ------- Almost done - building my mock cache so I can rebuild the package in mock. Last question: where is ImageMagick used in the build process?
MUST: rpmlint OK spec name OK license OK spec language OK spec readability OK source verification OK compilation (x86_64) OK BuildRequires OK files & directory ownerships OK
SHOULD: icon cache updated on post & postun OK
GAMES: - SGID dropped once score file opened OK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
michel.salim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From michel.salim@gmail.com 2006-11-11 00:54 EST ------- Package works OK in mock.
APPROVED (though I'm still curious where ImageMagick is used)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214985
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-11 03:05 EST ------- ImageMagick is needed for the convert command, which is used to convert the .ico file to a png file.
Thanks for the review! Imported and build, closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pachi - Pachi El Marciano - Platform Game
https://bugzilla.redhat.com/show_bug.cgi?id=214985
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org