--- Comment #2 from Dan Callaghan <dcallagh(a)redhat.com> ---
(In reply to comment #1)
There is a few bundled libraries ( besides the one that you already
bundling qt is just insane ) :
- linenoise ( likely modified )
I missed this one. Why do all these folks think that bundling all this junk in
their source is a good approach, instead of just linking against it? They have
even written scripts to automate the bundling process :-(
I might try porting phantomjs to readline instead. linenoise looks annoying,
the author states it is intended to be bundled... But at least phantomjs isn't
carrying any modifications to linenoise that I can find.
This one might be tricky... there is an old review request for coffeescript in
bug 732216, which was closed due to the problems with nodejs, but now that
nodejs is going to be landing in Fedora perhaps it can be revisited. I'm not
sure if coffeescript needs nodejs at runtime either. At any rate, phantomjs
uses only the pure js parts from it... so I'm not sure how that will work if
coffeescript is packaged as an npm package or whatever.
There is the directory ghostdriver, that bundle and modify code from
I think this one should stay. Ghostdriver support is linked into the phantomjs
binary, and ghostdriver is not usable without phantomjs. There is very close
cooperation between the authors of phantomjs and ghostdriver, and in fact I
suspect in the very near future ghostdriver will just be folded into phantomjs
there is a copy of qcommandline too.
I'm not sure what to do about this one. qcommandline has been declared dead by
its original author, and the phantomjs bundled version has lots of
modifications so it is essentially a fork. I saw some talk about switching
phantomjs over to a better-supported alternative in the future, not sure if
anyone is working on that though.
And given the mess that the tarball is from a license points of view,
think it may be easier for us to clean it.
- smaller tarball ( smaller srpm )
- less noise if someone decide to use coverty or anything on the code
- easier to review from a license and bundling point of view
- more work for you as you need to write a cleaning script and use it
Agreed that cleaning the tarball is worthwhile. I will work on a script for it.
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug