Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902025
--- Comment #7 from Scott Tsai <scottt.tw(a)gmail.com> ---
For your convenience, I've collected all my suggested changes to your spec file
here:
http://scottt.tw/fedora/pybugz.spec
Detailed review of the spec file:
1. Version naming (BIG one)
Per
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag,
please put the git revision in the release tag. In particular, as a
"Post-Release package" of the form %{X}.%{posttag}.
This is obviously very important to maintaining proper version sequences and
upgrade paths.
I recommend you treat this heavily patched snapshot based on 69cd7 as a post
"0.10" release (Though it's actually more recent than 0.10.1 upstream):
@@ -1,7 +1,11 @@
+%global gitrev 69cd7
+%global posttag git%{gitrev}
+%global snapshot %{version}%{posttag}
+
Name: pybugz
Summary: Command line interface for Bugzilla written in Python
-Version: 0.10git69cd7
-Release: 1%{?dist}
+Version: 0.10
+Release: 1.%{posttag}%{?dist}
Group: Applications/Communications
License: GPLv2
URL:
https://github.com/williamh/pybugz
@@ -10,9 +14,6 @@ BuildArch: noarch
Requires: python2
BuildRequires: python2-devel
-# we don't need debuginfo package
-%global debug_package %{nil}
-
%if ! 0%{?rhel}
# no bash-completion for RHEL
%global bash_completion 1
@@ -25,12 +26,12 @@ BuildRequires: bash-completion pkgconfig
# There is possible to download upstream tarball generated by github, but it
is
# quite old now. For HOWTO obtain correct tarball see the
"prepare-tarball.sh"
# script.
-Source0: %{name}-%{version}.tar.gz
+Source0: %{name}-%{snapshot}.tar.gz
# follow
https://github.com/praiskup/pybugz changes (until accepted by
upstream)
-Patch0: %{name}-%{version}-downstream.patch
+Patch0: %{name}-%{snapshot}-downstream.patch
# make the installation better satisfy RHEL / Fedora purposes
-Patch1: %{name}-%{version}-rhel-fedora-cust.patch
+Patch1: %{name}-%{snapshot}-rhel-fedora-cust.patch
%description
Pybugz was conceived as a tool to speed up the work-flow for Gentoo Linux
@@ -40,7 +41,7 @@ quickly. Developers alike can easily extract attachments and
close bugs
comfortably from the command line.
%prep
-%setup -q
+%setup -q -n %{name}-%{snapshot}
%patch0 -p1 -b .downstream
%patch1 -p1 -b .rhel-fedora-cust
@@ -55,7 +56,7 @@ comfortably from the command line.
%if %{?bash_completion}
# find the proper directory to install bash-completion script
mkdir -p %{buildroot}%{bash_cmpl_dir}
- cp %{_builddir}/%{name}-%{version}/contrib/bash-completion \
+ cp %{_builddir}/%{name}-%{snapshot}/contrib/bash-completion \
%{buildroot}%{bash_cmpl_dir}/bugz
%endif
The changelog would also need an update to match the new version scheme to
avoid rpmlint errors.
2. Defining "debug_package" to %{nul} shouldn't be necessary.
As stated in comment #6.
3. The "prepare-tarball.sh" script mentioned in the spec file is no where to be
found.
I'll approve this package once the problems above are addressed.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=95pXzuO3Qw&a=cc_unsubscribe