Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Summary: Review Request: kBuild - A cross-platform build enviroment Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lkundrak@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package- review@redhat.com,notting@redhat.com,opensource@till.nam e
SPEC: http://people.redhat.com/lkundrak/SPECS/kBuild.spec SRPM: http://people.redhat.com/lkundrak/SRPMS/kBuild-0.1.0-0.4.20070627svn.fc8.src...
A cross-platform build enviroment. This is used by VirtualBox.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
lkundrak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |kBuild-review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2008-02-28 22:43 EST ------- why this package have ExclusiveArch: %{ix86} x86_64 ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-02-29 00:25 EST ------- Parag: see where do we set BUILD_TARGET_ARCH. kBuild uses architecture name as part of file names and it seems to be only aware of "x86" and "amd64". That makes perfect sense -- it is only used to build VirtualBox and VirtualBox runs nowhere else.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From panemade@gmail.com 2008-02-29 01:28 EST ------- Thanks for reply. Reason to ask this is that I see some reviewers asking same thing as review should make sure new package builds on all archs. But if its not doing that then better to know reason and add that in SPEC.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From fedora@leemhuis.info 2008-03-01 07:57 EST ------- (In reply to comment #2)
[...] it is only used to build VirtualBox and VirtualBox runs nowhere else.
Just my 2 cent: I normally strongly prefer to "just call a package exactly like upstream calls its software". But for this package I'm starting to wonder if it might be better to call it VirtualBox-kbuild or something, to avoid confusion with the linux-kernel-internal kbuild infra.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-01 08:16 EST ------- I tend to agree with Thorsten and the name he suggested. Anyone has a different opinion?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From opensource@till.name 2008-03-01 09:22 EST ------- In theory, kBuild can be used to build anything and not only virtualbox, therefore I do not like the name very much. Also debian use only kBuild as a name for this package. In case there is a strong need to rename it, I would prefer something like "kBuild-makefile-framework", which describes it better.
Btw. one issue with the current kBuild spec is, that RPM_OPT_FLAGS are not used to compile it. But I do not currently know how to change this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-01 09:29 EST ------- (In reply to comment #6)
In theory, kBuild can be used to build anything and not only virtualbox, therefore I do not like the name very much. Also debian use only kBuild as a name for this package. In case there is a strong need to rename it, I would prefer something like "kBuild-makefile-framework", which describes it better.
That also makes sense. I'm do not dare how many users would confuse kBuild with kernel's build system, but I certainly wouldn't. In fact I can't imagine a scenario where that could occur.
Btw. one issue with the current kBuild spec is, that RPM_OPT_FLAGS are not used to compile it. But I do not currently know how to change this.
Thanks for telling that, I'm glad I avoided scop noticing that :)) I'll take care of that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-01 16:29 EST ------- Actually; kBuild is used to use something else than kBuild -- itself :)
I changed it to obey rpmflags.
Moreover binaries are installed to %{_bindir} where they belong. (For VirtualBox packagers: this probably won't build current package. Let us adjust it just once this is in Fedora repository)
Another change was to depend on itself, so that it does not have to be bootstrapped. It can, though, by definig bootstrap to 1.
Last change was to enable ppc32 and ppc64 builds. Seems like upstream counts on them.
http://people.redhat.com/lkundrak/SPECS/kBuild.spec http://people.redhat.com/lkundrak/SRPMS/kBuild-0.1.0-0.5.20070627svn.fc8.src...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From panemade@gmail.com 2008-03-02 23:07 EST ------- build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=485864
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-07 07:30 EST ------- http://people.redhat.com/lkundrak/SPECS/kBuild.spec http://people.redhat.com/lkundrak/SRPMS/kBuild-0.1.0-0.6.20070627svn.fc8.src...
ppc build: http://koji.fedoraproject.org/koji/taskinfo?taskID=500647
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From opensource@till.name 2008-03-07 08:29 EST ------- I forgot to mention this the last time:
The libexecdir does not need to created here, because nothing is installed there anymore: mkdir -p $RPM_BUILD_ROOT%{_libexecdir}/kBuild
But this can be changed before it is imported to cvs or when there is major change made before this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-07 08:35 EST ------- Till; thanks for noticing that. I'll wait for if Parag has any comments so I don't roll a new package just for this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From opensource@till.name 2008-03-08 06:16 EST ------- Another issue is to install kBuild with "kmk PATH_INS=${RPM_BUILD_ROOT} NIX_INSTALL_DIR=%{_prefix} install", then also the *.kmk scripts will be installed. This are the contents of the debian pacakage: http://packages.debian.org/sid/i386/kbuild/filelist
The problem is, that kmk install does not work with this version. I tried to build it with a snapshot from date 20071215 (this should be the release that debian uses), but then kmk install complained about expection kBuild version 0.1.2 but getting 0.1.0.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From panemade@gmail.com 2008-03-13 00:16 EST ------- Lubomir, Can you remove following line from SPEC? mkdir -p $RPM_BUILD_ROOT%{_libexecdir}/kBuild
any reason for not using latest svn checkout?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From lkundrak@redhat.com 2008-03-13 12:07 EST ------- (In reply to comment #13)
Another issue is to install kBuild with "kmk PATH_INS=${RPM_BUILD_ROOT} NIX_INSTALL_DIR=%{_prefix} install", then also the *.kmk scripts will be installed. This are the contents of the debian pacakage: http://packages.debian.org/sid/i386/kbuild/filelist
What are they good for? They are mostly useless even in context of building virtualbox itself (setting compiler flags to unwanted ones, etc.) and all we do during the build of kBuild is to struggle with them for influence on the flags.
(In reply to comment #14)
Lubomir, Can you remove following line from SPEC? mkdir -p $RPM_BUILD_ROOT%{_libexecdir}/kBuild
I'll do.
any reason for not using latest svn checkout?
Today's svn snapshot won't be latest tomorrow. This one is tried and works well for our purpose.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
------- Additional Comments From opensource@till.name 2008-03-13 13:01 EST ------- (In reply to comment #15)
(In reply to comment #13)
Another issue is to install kBuild with "kmk PATH_INS=${RPM_BUILD_ROOT} NIX_INSTALL_DIR=%{_prefix} install", then also the *.kmk scripts will be installed. This are the contents of the debian pacakage: http://packages.debian.org/sid/i386/kbuild/filelist
What are they good for? They are mostly useless even in context of building virtualbox itself (setting compiler flags to unwanted ones, etc.) and all we do during the build of kBuild is to struggle with them for influence on the flags.
Afaik, they are the same files that are in the kBuild directory in the virtualbox tarball and without them, the binaries within the package are useless, i.e. it does not really make sense to install the binaries in /usr/bin, because it could still not be used by projects that do not ship a local copy of kBuild.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|panemade@gmail.com |nobody@fedoraproject.org
------- Additional Comments From panemade@gmail.com 2008-04-03 23:40 EST ------- I better move away from this review. Till, feel free to review this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kBuild - A cross-platform build enviroment Alias: kBuild-review
https://bugzilla.redhat.com/show_bug.cgi?id=435276
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
------- Additional Comments From opensource@till.name 2008-04-04 05:26 EST ------- (In reply to comment #17)
I better move away from this review. Till, feel free to review this package.
I do not currently have the time to review this, also I doubt that it is ok with the spirit of the review process that I review this, because I wrote the initial spec of this packages.
Btw. you need to clear the fedora-review flag, when you step down as a reviewer, I did this now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #20 from Jason Tibbitts tibbs@math.uh.edu 2008-09-08 10:24:11 EDT --- Is the package from comment #10 the one which should be reviewed? Because those links are no longer valid.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #21 from Lubomir Rintel lkundrak@v3.sk 2008-09-08 12:04:09 EDT --- I've done some more work on this, I'll try to get in reviewable state and submit the new package shortly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
David Woodhouse dwmw2@infradead.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dwmw2@infradead.org Flag| |needinfo+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #22 from Jason Tibbitts tibbs@math.uh.edu 2008-11-05 11:07:32 EDT --- Any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
--- Comment #23 from Jason Tibbitts tibbs@math.uh.edu 2008-11-16 10:24:20 EDT --- Please clear the whiteboard when you are ready.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Xavier Lamien lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lxtnow@gmail.com
--- Comment #24 from Xavier Lamien lxtnow@gmail.com 2008-12-13 06:01:52 EDT --- ping ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #25 from Lubomir Rintel lkundrak@v3.sk 2008-12-14 15:14:37 EDT --- Boo!
SPEC: http://netbsd.sk/~lkundrak/SPECS/kBuild.spec SRPM: http://netbsd.sk/~lkundrak/SRPMS/kBuild-0.1.4-1.el5.src.rpm
* Builds in fedora-devel-i386 * RPMlint silent * If you type "google" into google, you'll break the internets!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|NotReady |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Xavier Lamien lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |lxtnow@gmail.com Flag|needinfo+ |fedora-review?
--- Comment #26 from Xavier Lamien lxtnow@gmail.com 2008-12-17 14:48:17 EDT --- taking review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Xavier Lamien lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #27 from Xavier Lamien lxtnow@gmail.com 2008-12-20 22:27:24 EDT --- Well, Everything looks good. Kbuild flags are properly set and built on all expected arches. According to packaging guideline, this package can be added.
Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #28 from Xavier Lamien lxtnow@gmail.com 2008-12-22 05:49:59 EDT --- btw, do you mind to add me as co-owner ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #29 from Lubomir Rintel lkundrak@v3.sk 2008-12-22 08:44:26 EDT --- (In reply to comment #28)
btw, do you mind to add me as co-owner ?
I'd be glad to. By the way, I noticed that you're planning to add VirtualBox into RPM Fusion, which I'm happy to hear, and which was the reason I added this review as well.
I don't know whether you package is finished, or whether you based your package on Till's one as well, but you may want to have a short look at my package, just to cross-check [1].
[1] http://elvn.getrpm.net/rpm/el5/src/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Xavier Lamien lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #30 from Xavier Lamien lxtnow@gmail.com 2008-12-23 11:30:50 EDT --- Thanks, I'll have a look and merge if so. Good to know you're involve in.
Package Request ================== Package names: kBuild Description: A cross-platform build environment Owners: lkundrak, laxathom Branches: F-8 F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
--- Comment #31 from Lubomir Rintel lkundrak@v3.sk 2008-12-23 15:49:05 EDT --- Package Request ================== Package names: kBuild Description: A cross-platform build environment Owners: lkundrak, laxathom Branches: EL-5 F-9 F-10
(Removing EOL-ed F-8, adding EPEL-5)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #32 from Kevin Fenzi kevin@tummy.com 2008-12-24 19:35:39 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435276
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #33 from Lubomir Rintel lkundrak@v3.sk 2008-12-25 09:59:48 EDT --- Imported and built. Thanks to Parag, Till, Xavier and Kevin.
Xavier: Please add me to Cc when you'll add a review request for VirtualBox in RPM Fusion. I'd eventually gladly review it, so you can assign it to me right away.
package-review@lists.fedoraproject.org